Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xerces-c] Fix dependencies #32259

Merged
merged 6 commits into from
Jul 5, 2023
Merged

[xerces-c] Fix dependencies #32259

merged 6 commits into from
Jul 5, 2023

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jun 27, 2023

Do not find libnsl:
The package doesn't use a single header from https://packages.debian.org/bookworm/amd64/libnsl-dev/filelist.
The alternative autotools buildsystem checks for the lib with regard to gethostbyname which is usually provided by libc, and checked separately in the CMake buildsystem.
Fixes #32170.

Add a default-feature network.

Updates dependency lookup and export - Fixes android builds.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@LilyWangLL LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label Jun 27, 2023
@dg0yt
Copy link
Contributor Author

dg0yt commented Jun 28, 2023

halide:x86-windows seems to be a baseline regression:
https://dev.azure.com/vcpkg/public/_build/results?buildId=91282&view=ms.vss-test-web.build-test-results-tab&runId=151214&resultId=100068&paneView=history
FTR it fails to run a tool which it builds:

FAILED: src/autoschedulers/adams2019/adams2019_cost_model.runtime.obj D:/buildtrees/halide/x86-windows-dbg/src/autoschedulers/adams2019/adams2019_cost_model.runtime.obj 
cmd.exe /C "cd /D D:\buildtrees\halide\x86-windows-dbg\src\autoschedulers\adams2019 && D:\buildtrees\halide\x86-windows-dbg\bin\_Halide_gengen.exe -r adams2019_cost_model.runtime -o . -e object target=x86-32-windows,x86-32-windows"

@dg0yt dg0yt marked this pull request as ready for review June 28, 2023 06:29
@dg0yt dg0yt changed the title [xerces-c] Control network dependencies [xerces-c] Fix dependencies Jun 28, 2023
@dg0yt dg0yt mentioned this pull request Jun 28, 2023
7 tasks
@LilyWangLL
Copy link
Contributor

Usage passed on x64-windows.

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jul 3, 2023
@vicroms vicroms merged commit 6359494 into microsoft:master Jul 5, 2023
@dg0yt dg0yt deleted the xerces-c branch July 5, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[xerces-c] hard coded path to libnsl.so
3 participants