Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[adios2] add port #29264

Merged
merged 10 commits into from
Feb 7, 2023
Merged

[adios2] add port #29264

merged 10 commits into from
Feb 7, 2023

Conversation

Neumann-A
Copy link
Contributor

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx (Hopefully)
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • [~] The generated "usage text" is accurate. See docs/examples/adding-an-explicit-usage.md for context. (Probably not if heuristic didn't get fixed.)
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

github-actions[bot]
github-actions bot previously approved these changes Jan 29, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for adios2 have changed but the version was not updated
version: 2.8.3
old SHA: 1c9640fe3792418ef650a030c5f729b5fed1cc17
new SHA: 40a6ba833d2633bb1b2daf704f19e5038f1690b0
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@Neumann-A Neumann-A marked this pull request as draft January 29, 2023 22:36
@Neumann-A
Copy link
Contributor Author

of course it fails because I build it with all features enabled .....

@Adela0814 Adela0814 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jan 30, 2023
github-actions[bot]
github-actions bot previously approved these changes Jan 31, 2023
github-actions[bot]
github-actions bot previously approved these changes Jan 31, 2023
@BillyONeal
Copy link
Member

I manually checked that the SHA in here is not affected by #29288

@Neumann-A Neumann-A marked this pull request as ready for review January 31, 2023 20:52
ports/adios2/portfile.cmake Outdated Show resolved Hide resolved
ports/adios2/portfile.cmake Outdated Show resolved Hide resolved
ports/adios2/portfile.cmake Outdated Show resolved Hide resolved
@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Feb 7, 2023
@JavierMatosD JavierMatosD merged commit 2d0bfea into microsoft:master Feb 7, 2023
@Neumann-A Neumann-A deleted the add_adios2 branch February 8, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants