-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opentelemetry-cpp] update version to 1.4.1 #25873
Conversation
I'm not sure why, but the dependent package
Seems like it should work, as the version is greater than 1.3.0, but it doesn't. |
@LarryOsterman,Could you please look this plan feasible? |
@JonLiu1993 patch added, all checks are passing now. Thanks for the pointers. |
All features are tested successfully in the following triplet:
|
I asked Azure folks to comment on the patch to their bits. |
ports/azure-core-tracing-opentelemetry-cpp/use-opentelemetry-cpp-141.patch
Outdated
Show resolved
Hide resolved
Thank you, will implement these changes |
…emetry version instead of using 1.4.1
ba014f5
@BillyONeal implemented your suggestions and all checks are passing. Let me know if anything else needs to be done |
Thanks for the update! |
Describe the pull request
What does your PR fix?
Update opentelemetry-cpp port to the latest version v1.4.1.
Which triplets are supported/not supported? Have you updated the CI baseline?
all, No
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/