Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opentelemetry-cpp] update version to 1.4.1 #25873

Merged
merged 7 commits into from
Jul 22, 2022

Conversation

joaosoares
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    Update opentelemetry-cpp port to the latest version v1.4.1.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, No

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@ghost
Copy link

ghost commented Jul 19, 2022

CLA assistant check
All CLA requirements met.

@joaosoares joaosoares marked this pull request as draft July 19, 2022 20:44
@joaosoares joaosoares marked this pull request as ready for review July 19, 2022 21:29
@joaosoares
Copy link
Contributor Author

I'm not sure why, but the dependent package azure-core-tracing-opentelemetry-cpp is failing with the message

No transport adapter was selected, using libcurl as the default option for POSIX.
CMake Error at /Users/joao/Projects/vcpkg/scripts/buildsystems/vcpkg.cmake:824 (_find_package):
  Could not find a configuration file for package "opentelemetry-cpp" that is
  compatible with requested version "1.3.0".

  The following configuration files were considered but not accepted:

    /Users/joao/Projects/vcpkg/installed/x64-osx/share/opentelemetry-cpp/opentelemetry-cpp-config.cmake, version: 1.4.1

Call Stack (most recent call first):
  CMakeLists.txt:39 (find_package)

Seems like it should work, as the version is greater than 1.3.0, but it doesn't.

@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Jul 20, 2022
github-actions[bot]
github-actions bot previously approved these changes Jul 20, 2022
@JonLiu1993
Copy link
Member

I'm not sure why, but the dependent package azure-core-tracing-opentelemetry-cpp is failing with the message

No transport adapter was selected, using libcurl as the default option for POSIX.
CMake Error at /Users/joao/Projects/vcpkg/scripts/buildsystems/vcpkg.cmake:824 (_find_package):
  Could not find a configuration file for package "opentelemetry-cpp" that is
  compatible with requested version "1.3.0".

  The following configuration files were considered but not accepted:

    /Users/joao/Projects/vcpkg/installed/x64-osx/share/opentelemetry-cpp/opentelemetry-cpp-config.cmake, version: 1.4.1

Call Stack (most recent call first):
  CMakeLists.txt:39 (find_package)

Seems like it should work, as the version is greater than 1.3.0, but it doesn't.

@joaosoares, This error is because azure-core-tracing-opentelemetry-cpp set https://github.com/Azure/azure-sdk-for-cpp/blob/584f83c7bd0399a5c473508c459d3e11fcf2c764/sdk/core/azure-core-tracing-opentelemetry/CMakeLists.txt#L39

find_package(opentelemetry-cpp "1.3.0" CONFIG REQUIRED)

so when you update opentelemetry-cpp from "1.3.0" to "1.4.1" made

  Could not find a configuration file for package "opentelemetry-cpp" that is
  compatible with requested version "1.3.0".

The soultion: Port: azure-core-tracing-opentelemetry-cpp vcpkg.json file:

    {
      "name": "opentelemetry-cpp",
      "version>=": "1.3.0"
    },

->

    {
      "name": "opentelemetry-cpp",
      "version>=": "1.4.1"
    },

Make a patch file: file: https://github.com/Azure/azure-sdk-for-cpp/blob/584f83c7bd0399a5c473508c459d3e11fcf2c764/sdk/core/azure-core-tracing-opentelemetry/CMakeLists.txt#L39

find_package(opentelemetry-cpp "1.3.0" CONFIG REQUIRED)

->

find_package(opentelemetry-cpp "1.4.1" CONFIG REQUIRED)

@LarryOsterman,Could you please look this plan feasible?

@joaosoares
Copy link
Contributor Author

joaosoares commented Jul 20, 2022

@JonLiu1993 patch added, all checks are passing now. Thanks for the pointers.

github-actions[bot]
github-actions bot previously approved these changes Jul 21, 2022
JonLiu1993
JonLiu1993 previously approved these changes Jul 21, 2022
@JonLiu1993
Copy link
Member

All features are tested successfully in the following triplet:

  • x64-linux

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jul 21, 2022
@BillyONeal
Copy link
Member

I asked Azure folks to comment on the patch to their bits.

@BillyONeal BillyONeal added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Jul 22, 2022
@joaosoares
Copy link
Contributor Author

Thank you, will implement these changes

@joaosoares
Copy link
Contributor Author

@BillyONeal implemented your suggestions and all checks are passing. Let me know if anything else needs to be done

github-actions[bot]
github-actions bot previously approved these changes Jul 22, 2022
@BillyONeal BillyONeal added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jul 22, 2022
@BillyONeal
Copy link
Member

Thanks for the update!

@BillyONeal BillyONeal merged commit 0032302 into microsoft:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants