[azure-core-tracing-opentelemetry-cpp | azure-core-cpp] Add new port and publish azure-core-cpp version to 1.0.0-beta.2 #25507
Conversation
## 1.0.0-beta.2 (2022-06-30) ### Breaking Changes - The `Azure::Core::Tracing::OpenTelemetry::OpenTelemetryProvider` type can only be instantiated via a factory method: `OpenTelemetryProvider::Create()`. ### Other Changes - Removed `_internal` APIs from the public API surface. Also removed most of the `_internal` APIs from the public `opentelemetry.hpp` headers.
|
Adding azure-core-tracing-opentelemetry to release cc: @RickWinter, @ahsonkhan, @antkmsft, @vhvb1989, @gearama, @LarryOsterman |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
## 1.7.0 (2022-06-30) ### Features Added - Added prototypes and initial service support for Distributed Tracing.
|
Adding azure-core to release cc: @RickWinter, @ahsonkhan, @antkmsft, @vhvb1989, @gearama, @LarryOsterman |
JonLiu1993
added
category:port-update
JonLiu1993
changed the title
|
All features are tested successfully in the following triplet:
|
| @@ -10,8 +10,7 @@ | |||
| "dependencies": [ | |||
| { | |||
| "name": "openssl", | |||
| "platform": "!windows & !uwp", | |||
| "version>=": "1.1.1n" | |||
There was a problem hiding this comment.
Note: This isn't the only Azure port using version>=
There was a problem hiding this comment.
Why remove the platform restriction - is openssl used on Windows?
Why remove the version restriction?
There was a problem hiding this comment.
- OpenSSL is used on both Windows and Linux.
"version>="requires semantic versioning. The text "1.1.1n" is not a valid semantic version.
It's a bug in the vcpkg tooling that this is allowed.
There was a problem hiding this comment.
It should work for all schemes. But version-string is different indeed, >= only applies to port-version, 1.1.1n would need to match exactly. (Maybe it should just ask for 3.0.0.)
There was a problem hiding this comment.
One alternative to updating the version dependency is to simply remove the version dependency from the package definition.
Why do we need to have a specific package version?
@BillyONeal Do you know of a reason we should add back our package version dependency for azure-core?
There was a problem hiding this comment.
Umm. We are currently using OpenSSL 3.0.x, so the bespoke version number is irrelevant. My change above removes the dependency on the bespoke version number.
Given that we're no longer using the bespoke version number, why do I need to explicitly provide a version number for OpenSSL?
And if we're required to provide a version number for OpenSSL, why aren't we required to provide a version number for the other packages we depend on?
There was a problem hiding this comment.
Yeah, it is not needed anymore. I could see an argument for changing it to >=3.0.0 to disallow old 1.1.1* versions if you want that.
There was a problem hiding this comment.
@LarryOsterman, should we put >=3.0.0 here? Let's get this PR merged, so that #25629 can be merged after that.
There was a problem hiding this comment.
I'm not sure it's worth re-releasing the package to add it. As the package is currently written, it is correct.
In the future we might want to consider adding the OpenSSL dependency.
There was a problem hiding this comment.
@BillyONeal, @vicroms is this PR ready to merge, as-is, or is there a correctness change we need to make?
| { | ||
| "name": "azure-core-cpp", | ||
| "default-features": false, | ||
| "version>=": "1.7.0-beta.1" |
There was a problem hiding this comment.
This won't have any effect
There was a problem hiding this comment.
Why doesn't it have any effect?
How do I author a package version restriction to reflect that a package depends on another package version?
There was a problem hiding this comment.
I believe that this will have an effect, if for example someone's baseline doesn't include this port version and the user tries to pick a newer one with a constraint themselves. But yes, most customers will be updating to a baseline where this constraint is meaningless.
There was a problem hiding this comment.
FWIW, Billy's logic is explicitly why the version requirement is there. We need this to fail if the customer's baseline does not include 1.7.0-beta.1.
dan-shaw
added
requires:vcpkg-team-review
vicroms
added
requires:author-response
and removed
requires:vcpkg-team-review
ahsonkhan
deleted the
azure-sdk-for-cpp-azure-core-tracing-opentelemetry-1678545
branch
Update vcpkg ports for Azure SDK release. This release may contain multiple ports.