[websocketpp] Patching websocketpp for c++20 support #23669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faserg1
force-pushed
the
websocketpp-cxx20-patch
branch
from
42d1637 to
bdc869b
Compare
LilyWangLL
changed the title
LilyWangLL
added
the
category:port-feature
|
Thanks for your work. Does this change will affect other CXX version? And this change should sync on upstream https://github.com/zaphoyd/websocketpp. Could you submit an issue or PR to report this PR on upstream? |
|
This is fix because of C++20 deprecation, and fix valid for lower CXX version (https://timsong-cpp.github.io/cppwp/n4861/diff.cpp17.class#2). This is a temporary patch, before new version released. |
LilyWangLL
added
info:reviewed
|
Thanks for the patch :). For what it's worth, this isn't a C++20 thing, this has always been ill formed. |
7 tasks
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Nov 4, 2023
websocketpp had some ill-formed usage of template parameters which was finally removed in C++20. Hence build fails when building with C++20 support enabled. The patch is already in the develop branch but no new release was done. There are no autobuilder failures because websocketpp is a header-only library, and there are no packages in Buildroot that depned on websocketpp. A build issue was encountered when bumping an internal project to C++20. This issue triggered quite some bug reports in the project [0] and there are backports to other package managers like vcpkg [1] and conan [2]. [0] zaphoyd/websocketpp#1060 [1] microsoft/vcpkg#23669 [2] conan-io/conan-center-index#15295 Signed-off-by: Michael Nosthoff <[email protected]> [Thomas: extend commit log with details provided by Michael.] Signed-off-by: Thomas Petazzoni <[email protected]>
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Nov 8, 2023
websocketpp had some ill-formed usage of template parameters which was finally removed in C++20. Hence build fails when building with C++20 support enabled. The patch is already in the develop branch but no new release was done. There are no autobuilder failures because websocketpp is a header-only library, and there are no packages in Buildroot that depned on websocketpp. A build issue was encountered when bumping an internal project to C++20. This issue triggered quite some bug reports in the project [0] and there are backports to other package managers like vcpkg [1] and conan [2]. [0] zaphoyd/websocketpp#1060 [1] microsoft/vcpkg#23669 [2] conan-io/conan-center-index#15295 Signed-off-by: Michael Nosthoff <[email protected]> [Thomas: extend commit log with details provided by Michael.] Signed-off-by: Thomas Petazzoni <[email protected]> (cherry picked from commit 9ac1a76) Signed-off-by: Peter Korsgaard <[email protected]>
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Nov 8, 2023
websocketpp had some ill-formed usage of template parameters which was finally removed in C++20. Hence build fails when building with C++20 support enabled. The patch is already in the develop branch but no new release was done. There are no autobuilder failures because websocketpp is a header-only library, and there are no packages in Buildroot that depned on websocketpp. A build issue was encountered when bumping an internal project to C++20. This issue triggered quite some bug reports in the project [0] and there are backports to other package managers like vcpkg [1] and conan [2]. [0] zaphoyd/websocketpp#1060 [1] microsoft/vcpkg#23669 [2] conan-io/conan-center-index#15295 Signed-off-by: Michael Nosthoff <[email protected]> [Thomas: extend commit log with details provided by Michael.] Signed-off-by: Thomas Petazzoni <[email protected]> (cherry picked from commit 9ac1a76) Signed-off-by: Peter Korsgaard <[email protected]>
evilquinn
added a commit
to evilquinn/projeul
that referenced
this pull request
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Adding GCC 11 C++20 support (In basic.hpp, a few compiling error with g++11, C++20, zaphoyd/websocketpp#991)
Which triplets are supported/not supported? Have you updated the CI baseline?
I have not updated CI baseline.
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes,
./vcpkg x-add-version websocketpp