Adding port file for v8 #2324

tkerwin · 2017-12-07T19:20:11Z

v8 has a quite convoluted build system.
This is the general sequence of events:

Fetch and unzip Google's "depot_tools"
Update depot_tools
Pull v8 code via depot_tools
Generate build framework via depot_tools
Append commands to build config file
Call ninja to perform the build
Install header and library files

Make sure to initialize the Visual Studio command line environment before running vcpkg install v8:x64-windows i.e. run "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\vcvars64.bat" or the equivalent on your system

Fixes #372

windoze · 2017-12-11T16:12:58Z

Hi, I've tried your port, but there're some issues.

It complained about the depot_tools.zip hash mismatch, I guess Chromium team just made some updates.
It complained that it cannot find git

CMake Error at C:/tools/vcpkg/scripts/cmake/vcpkg_execute_required_process.cmake:44 (message):
    Command failed: GIT_EXECUTABLE-NOTFOUND;checkout;branch-heads/6.3
    Working Directory: C:/tools/vcpkg/buildtrees/v8/src/v8/v8
    See logs for more information:
      C:\tools\vcpkg\buildtrees\v8\x64-windows-out.log
      C:\tools\vcpkg\buildtrees\v8\x64-windows-err.log

Call Stack (most recent call first):
  C:/tools/vcpkg/ports/v8/portfile.cmake:69 (vcpkg_execute_required_process)
  C:/tools/vcpkg/scripts/ports.cmake:72 (include)

2 logs files are empty, and I'm pretty sure Git.exe is installed and on the path.

tkerwin · 2017-12-11T19:18:12Z

Thanks for trying it out. Before that error, was there an output line that says "Git found: [something]"? Perhaps find_package(Git) is failing for some reason.

windoze · 2017-12-11T20:10:21Z

Here is the full output:

vcpkg install v8:x64-windows

The following packages will be built and installed:
    v8:x64-windows
Starting package 1/1: v8:x64-windows
Building package v8:x64-windows...
-- CURRENT_INSTALLED_DIR=C:/tools/vcpkg/installed/x64-windows
-- DOWNLOADS=C:/tools/vcpkg/downloads
-- CURRENT_PACKAGES_DIR=C:/tools/vcpkg/packages/v8_x64-windows
-- CURRENT_BUILDTREES_DIR=C:/tools/vcpkg/buildtrees/v8
-- CURRENT_PORT_DIR=C:/tools/vcpkg/ports/v8/.
-- Using cached C:/tools/vcpkg/downloads/depot_tools.zip
-- Testing integrity of cached file...
-- Testing integrity of cached file... OK
-- Extracting done
-- Updating depot_tools...
-- Switching to checkout of v8 version 6.3
-- Could NOT find Git (missing: GIT_EXECUTABLE)
CMake Error at C:/tools/vcpkg/scripts/cmake/vcpkg_execute_required_process.cmake:44 (message):
    Command failed: GIT_EXECUTABLE-NOTFOUND;checkout;branch-heads/6.3
    Working Directory: C:/tools/vcpkg/buildtrees/v8/src/v8/v8
    See logs for more information:
      C:\tools\vcpkg\buildtrees\v8\x64-windows-out.log
      C:\tools\vcpkg\buildtrees\v8\x64-windows-err.log

Call Stack (most recent call first):
  C:/tools/vcpkg/ports/v8/portfile.cmake:69 (vcpkg_execute_required_process)
  C:/tools/vcpkg/scripts/ports.cmake:72 (include)


Error: Building package v8:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: v8:x64-windows
  Vcpkg version: 0.0.100-2017-12-09-9f0d33b6ad3af842b133aafa8be1bbf63e08201d

Additionally, attach any relevant sections from the log files above.

where git
C:\Program Files\Git\cmd\git.exe

Seems it failed to find git, which I've installed with Chocolatey.

choco list -li
...
git 2.15.1.2
git.install 2.15.1.2
...

ghost · 2017-12-13T05:49:11Z

Can you edit your initial post to contain "Fixes #372"?

windoze · 2017-12-14T07:26:17Z

It's weird that suddenly FindGit worked, but there was a new issue:

vcpkg install v8:x64-windows
The following packages will be built and installed:
    v8:x64-windows
Starting package 1/1: v8:x64-windows
Building package v8:x64-windows...
-- CURRENT_INSTALLED_DIR=C:/tools/vcpkg/installed/x64-windows
-- DOWNLOADS=C:/tools/vcpkg/downloads
-- CURRENT_PACKAGES_DIR=C:/tools/vcpkg/packages/v8_x64-windows
-- CURRENT_BUILDTREES_DIR=C:/tools/vcpkg/buildtrees/v8
-- CURRENT_PORT_DIR=C:/tools/vcpkg/ports/v8/.
-- Using cached C:/tools/vcpkg/downloads/depot_tools.zip
-- Testing integrity of cached file...
-- Testing integrity of cached file... OK
-- Extracting source C:/tools/vcpkg/downloads/depot_tools.zip
-- Extracting done
-- Updating depot_tools...
-- Initial fetch of v8 git repository
-- Generating build directory x64.optdebug
-- Setting configuration for shared library build
-- Building x64.optdebug through ninja
-- Generating build directory x64.release
-- Setting configuration for shared library build
-- Building x64.release through ninja
-- Installing: C:/tools/vcpkg/packages/v8_x64-windows/share/v8/copyright
-- Installing: C:/tools/vcpkg/packages/v8_x64-windows/include
-- Installing: C:/tools/vcpkg/packages/v8_x64-windows/include/libplatform
-- Installing: C:/tools/vcpkg/packages/v8_x64-windows/include/libplatform/libplatform-export.h
-- Installing: C:/tools/vcpkg/packages/v8_x64-windows/include/libplatform/libplatform.h
-- Installing: C:/tools/vcpkg/packages/v8_x64-windows/include/libplatform/v8-tracing.h
-- Installing: C:/tools/vcpkg/packages/v8_x64-windows/include/v8-debug.h
-- Installing: C:/tools/vcpkg/packages/v8_x64-windows/include/v8-inspector-protocol.h
-- Installing: C:/tools/vcpkg/packages/v8_x64-windows/include/v8-inspector.h
-- Installing: C:/tools/vcpkg/packages/v8_x64-windows/include/v8-platform.h
-- Installing: C:/tools/vcpkg/packages/v8_x64-windows/include/v8-profiler.h
-- Installing: C:/tools/vcpkg/packages/v8_x64-windows/include/v8-testing.h
-- Installing: C:/tools/vcpkg/packages/v8_x64-windows/include/v8-util.h
-- Installing: C:/tools/vcpkg/packages/v8_x64-windows/include/v8-value-serializer-version.h
-- Installing: C:/tools/vcpkg/packages/v8_x64-windows/include/v8-version-string.h
-- Installing: C:/tools/vcpkg/packages/v8_x64-windows/include/v8-version.h
-- Installing: C:/tools/vcpkg/packages/v8_x64-windows/include/v8.h
-- Installing: C:/tools/vcpkg/packages/v8_x64-windows/include/v8config.h
CMake Error at C:/tools/vcpkg/ports/v8/portfile.cmake:147 (file):
  file INSTALL cannot find
  "C:/tools/vcpkg/buildtrees/v8/src/v8/v8/out.gn/x64.release/v8.dll".
Call Stack (most recent call first):
  C:/tools/vcpkg/scripts/ports.cmake:72 (include)


Error: Building package v8:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: v8:x64-windows
  Vcpkg version: 0.0.100-2017-12-09-9f0d33b6ad3af842b133aafa8be1bbf63e08201d

Additionally, attach any relevant sections from the log files above.

x64-windows-err.log:

c:\tools\vcpkg\buildtrees\v8\src\v8\v8\third_party\_gclient_gittmp_instrumented_librariesy9byp3\shallow - The process cannot access the file because it is being used by another process.

windoze · 2017-12-14T08:34:20Z

ok, I'v found the problem.
For some reason, ninja didn't build "v8.dll" when it's building "v8-shell.exe", I added "v8.dll" target in portfile.cmake:103 and portfile.cmake:133 and the issue's gone.

And there is another problem, looks that this port doesn't copy natives_blob.bin and snapshot.bin into installed directory, I've to copy them from the buildtrees to make a hello world program to run.

BTW, does this port support static build?

tkerwin · 2017-12-14T17:44:26Z

I haven't tried static build, but I'll give it a shot.
The requirement on native_blob.bin and snapshot.bin should be removed by the line:
file(APPEND ${SOURCE_PATH}/v8/v8/out.gn/${BUILDTYPE}/args.gn "v8_use_external_startup_data = false" )

That's how I did it when I had that problem, but it's already in portfile.cmake, so I'm not sure why you're seeing the issue.

tkerwin · 2017-12-14T19:20:51Z

I think maybe the depot tools update affected the v8.dll build issue. I wasn't seeing it before, and now I am.

tkerwin · 2017-12-14T21:51:55Z

I think the new depot_tools might have changed something with the build.ninja generation. For the x64.optdebug build, it has build v8: phony ./v8.dll.lib, but in x64.release, it has build v8: phony obj/v8.stamp. The dlls are built correctly in the first case but not for release.

windoze · 2017-12-15T06:09:30Z

I see the problem, in portfile.cmake:95, you forgot to add a "\n" at the line end, so the generated args.gn was like:

...
visual_studio_version = "2017"v8_use_external_startup_data = false

tkerwin · 2017-12-20T15:34:02Z

The latest fixes work better for me. the v8.dll problem seemed to be some strange side effect of them updating the depot_tools, so I generated the build files using a different method.

icedream2linxi

Do you consider Linux and MacOS?

是否考虑下 Linux 和 MacOS?

icedream2linxi · 2018-08-18T13:52:31Z

ports/v8/portfile.cmake

+
+include(vcpkg_common_functions)
+set(SOURCE_PATH ${CURRENT_BUILDTREES_DIR}/src)
+vcpkg_download_distfile(ARCHIVE


depot_tools.zip will change with the version, why not directly git clone?

depot_tools.zip 会随着版本变化，为什么不直接 git clone ？

icedream2linxi · 2018-08-18T13:54:51Z

ports/v8/portfile.cmake

+vcpkg_execute_required_process(
+    COMMAND ${SOURCE_PATH}/gclient.bat
+    WORKING_DIRECTORY ${SOURCE_PATH}
+    LOGNAME ${TARGET_TRIPLET}


This is the same as the log name that follows, which can lead to indistinguishable.

这里与后面的日志名称相同，会导致无法区分。

icedream2linxi · 2018-08-20T02:53:37Z

ports/v8/portfile.cmake

+
+message(STATUS "Switching to checkout of v8 version 6.3")
+
+find_package(Git)


Use find_program(GIT NAMES git git.cmd), for example vcpkg_apply_patches.cmake.

使用 find_program(GIT NAMES git git.cmd)，例如vcpkg_apply_patches.cmake。

icedream2linxi · 2018-08-20T04:22:22Z

ports/v8/portfile.cmake

+    WORKING_DIRECTORY ${SOURCE_PATH}/v8/v8
+    LOGNAME ${TARGET_TRIPLET}
+)
+


Sync is required after checkout because checkout does not update submodule to the appropriate version.

checkout 后需要 sync，因为 checkout 并没有将 submodule 更新到合适版本。

ivanmoskalev · 2018-11-13T08:34:24Z

Is there any particular reason why this PR is suspended?
I need v8 in my project, and I'd prefer to add it through the vcpkg, so I might try and help the author to merge this.

Rastaban · 2019-01-19T00:23:36Z

ug, I had a few updates to this PR but ended up making a mess when pushing my change because of how I merged the latest master branch into it. I attempted to force-push to undo the mess but it ended up closing the PR. I have stuck all the changes into dev/philc/tkerwin-master for now until I can sort it all out.

crackedmind mentioned this pull request Jan 12, 2018

Add support for v8 port #2560

Closed

icedream2linxi reviewed Aug 19, 2018

View reviewed changes

icedream2linxi reviewed Aug 20, 2018

View reviewed changes

Rastaban closed this Jan 19, 2019

Rastaban force-pushed the master branch from 53660a2 to 2d0e674 Compare January 19, 2019 00:11

JackBoosY mentioned this pull request Apr 23, 2019

[v8]Add v8 support #6184

Closed

JackBoosY mentioned this pull request Nov 14, 2019

[v8, vcpkg_find_acquire_program, vcpkg_<sync/configure/build>_gn] Add new port; support depot-tools #8963

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding port file for v8 #2324

Adding port file for v8 #2324

tkerwin commented Dec 7, 2017 •

edited

Loading

windoze commented Dec 11, 2017 •

edited

Loading

tkerwin commented Dec 11, 2017

windoze commented Dec 11, 2017 •

edited

Loading

ghost commented Dec 13, 2017

windoze commented Dec 14, 2017 •

edited

Loading

windoze commented Dec 14, 2017 •

edited

Loading

tkerwin commented Dec 14, 2017 •

edited

Loading

tkerwin commented Dec 14, 2017

tkerwin commented Dec 14, 2017

windoze commented Dec 15, 2017

tkerwin commented Dec 20, 2017

icedream2linxi left a comment

icedream2linxi Aug 18, 2018

icedream2linxi Aug 18, 2018

icedream2linxi Aug 20, 2018

icedream2linxi Aug 20, 2018

ivanmoskalev commented Nov 13, 2018 •

edited

Loading

Rastaban commented Jan 19, 2019


		message(STATUS "Switching to checkout of v8 version 6.3")

		find_package(Git)

Adding port file for v8 #2324

Adding port file for v8 #2324

Conversation

tkerwin commented Dec 7, 2017 • edited Loading

windoze commented Dec 11, 2017 • edited Loading

tkerwin commented Dec 11, 2017

windoze commented Dec 11, 2017 • edited Loading

ghost commented Dec 13, 2017

windoze commented Dec 14, 2017 • edited Loading

windoze commented Dec 14, 2017 • edited Loading

tkerwin commented Dec 14, 2017 • edited Loading

tkerwin commented Dec 14, 2017

tkerwin commented Dec 14, 2017

windoze commented Dec 15, 2017

tkerwin commented Dec 20, 2017

icedream2linxi left a comment

Choose a reason for hiding this comment

icedream2linxi Aug 18, 2018

Choose a reason for hiding this comment

icedream2linxi Aug 18, 2018

Choose a reason for hiding this comment

icedream2linxi Aug 20, 2018

Choose a reason for hiding this comment

icedream2linxi Aug 20, 2018

Choose a reason for hiding this comment

ivanmoskalev commented Nov 13, 2018 • edited Loading

Rastaban commented Jan 19, 2019

tkerwin commented Dec 7, 2017 •

edited

Loading

windoze commented Dec 11, 2017 •

edited

Loading

windoze commented Dec 11, 2017 •

edited

Loading

windoze commented Dec 14, 2017 •

edited

Loading

windoze commented Dec 14, 2017 •

edited

Loading

tkerwin commented Dec 14, 2017 •

edited

Loading

ivanmoskalev commented Nov 13, 2018 •

edited

Loading