-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BLAS] add metaport #13448
[BLAS] add metaport #13448
Conversation
Note: I added f90ffde commit to keep current BLAS setup also on macOS. It's an open question if we should use Apple Accelerate framework there by default (and in this case just reverting the commit and make blas depend on openblas(!osx) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to update Port-Version for other ports?
Any feedback here to consider for merging? |
I noticed that Note: Seems need to resolve the conflicts caused by |
Ok but @ras0219 requested port version bump only for clapack, I assume the others are ok in this way |
@NancyLi1013 may I ask why "requires:author-response"? |
@cenit |
/azp run |
No pipelines are associated with this pull request. |
Could you please resolve the conflicts and also merge master? |
LGTM now, thanks for your PR @cenit. |
@BillyONeal i copy-pasted same exact messages and behavior from the lapack port! But I will modify pr according to your review. About the openblas(!osx), it’s a residual from the past. In the beginning I did a pr to exclude OpenBLAS and clapack from Ports using them on osx, because the accelerate framework was better. Then lapack-reference came and it superseded the behavior, to uniform platform better. This made OpenBLAS the default everywhere, too. |
@Neumann-A Can you explain what those comments are saying that were added in #12464 ? It seems like the /cc @strega-nil |
@BillyONeal: there was a external/extern feature once but somebody did not like it. The idea was if you install |
@Neumann-A I see, so the comment is just wrong and should be removed from both places? |
@BillyONeal: I still think the port should be used to test if |
@Neumann-A That's fine, I'm objecting to the comment, not the behavior |
Thanks @cenit, this is great :) |
Almost identical to LAPACK approach, I am suggesting this metaport to ease BLAS+LAPACK port override (macOS Accelerate framework is almost the only one working properly on the upcoming Apple Silicon)