-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[protobuf] Correct protobuf under android (Fix issue #8218) #11228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This fixes microsoft#8218 The original error is linkely inside protobuf CMakeLists, which should link the log library under Android. See explanations here: protocolbuffers/protobuf#2719
pthom
force-pushed
the
fix_protobuf_android
branch
from
May 7, 2020 19:55
194172d
to
c7a466a
Compare
LilyWangL
changed the title
Correct protobuf under android (Fix issue #8218)
[protobuf] Correct protobuf under android (Fix issue #8218)
May 8, 2020
JackBoosY
suggested changes
May 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the version info. See documentation.
@smzahraee Could you test this PR? Thanks. |
Done, I switched from 3.11.4 to 3.11.4-1 |
JackBoosY
approved these changes
May 8, 2020
LGTM. |
LGTM, thanks @pthom :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This PR fixes and issue for protobuf when building for Android.
When linking, an error "undefined reference to '__android_log_write' was happening.
The original error is likely inside protobuf CMakeLists, which should link the log library under Android: see this issue in protobuf repo
This fixes #8218
Which triplets are supported/not supported?
There is no official Android triplet at the moment. I will add an example triplet below.
Have you updated the CI baseline?
No
Does your PR follow the maintainer guide?
Yes
There is no official android triplet file. So, I provide an example one below. May be it could be an inspiration for a triplet in the community folder (however I am not an android expert).
Steps to reproduce the build
triplets/android-armeabi-v7a.cmake
Download and install the android ndk-bundle
Set an env var to the ndk-bundle folder