Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make artifacts use common console handling. #1165

Merged
merged 8 commits into from
Aug 30, 2023
Merged

Make artifacts use common console handling. #1165

merged 8 commits into from
Aug 30, 2023

Conversation

BillyONeal
Copy link
Member

This resolves the missing vcpkg help entries noted in #1164

This must not be merged until it passes design review.

@Thomas1664
Copy link
Contributor

constexpr CommandSwitch CommandNameSwitches[] and the arrays operating_systems, target_platforms, host_platforms are duplicated in a few places. Would it be possible to put them in one .inc.h file like localization messages?

@BillyONeal BillyONeal mentioned this pull request Aug 26, 2023
Merged
@BillyONeal BillyONeal merged commit 117a5e6 into microsoft:main Aug 30, 2023
5 checks passed
@BillyONeal BillyONeal deleted the add-missing-args branch August 30, 2023 21:01
@BillyONeal BillyONeal mentioned this pull request Oct 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft ras0219-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BillyONeal @Thomas1664 @ras0219-msft