Properly exclude operation templates when scanning for routes #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviwil
requested review from
bterlson,
nguerrera,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/600/ |
daviwil
force-pushed
the
fix-template-operation-exclusion
branch
from
1b2b609
to
a1388d5
Compare
timotheeguerin
approved these changes
Jun 8, 2022
daviwil
force-pushed
the
fix-template-operation-exclusion
branch
from
a1388d5
to
0b65602
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a bug in the
restlibrary change I made for PR #552 where I tried to exclude templated operations when we scan for routes in namespaces. This small change checksop.node.templateParametersinstead ofop.templateArgumentswhen determining if an operation is templated.This is related to PR https://github.com/Azure/cadl-azure/pull/1556.