Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openapi3] Add missing peer dependency "openapi-types" #5274

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

mikeharder
Copy link
Contributor

Fixes warnings (or potentially errors) when installing @typespec/openapi3:

$ npx yarn add @typespec/[email protected]

yarn add v1.22.22
info No lockfile found.
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...

warning " > @typespec/[email protected]" has unmet peer dependency "@typespec/compiler@~0.62.0".
warning " > @typespec/[email protected]" has unmet peer dependency "@typespec/http@~0.62.0".
warning " > @typespec/[email protected]" has unmet peer dependency "@typespec/versioning@~0.62.0".
warning " > @typespec/[email protected]" has unmet peer dependency "@typespec/openapi@~0.62.0".

warning "@typespec/openapi3 > @readme/[email protected]" has unmet peer dependency "openapi-types@>=7".

The first 4 warnings are expected, but the peer dependency on openapi-types should either be satisfied by @typespec/openapi3 itself, or be declared as a peer dependency of @typespec/openapi3 itself.

@azure-sdk
Copy link
Collaborator

All changed packages have been documented.

  • @typespec/openapi3
Show changes

@typespec/openapi3 - fix ✏️

Added missing peer dependency "openapi-types"

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@mikeharder mikeharder enabled auto-merge December 5, 2024 19:05
@mikeharder mikeharder added this pull request to the merge queue Dec 5, 2024
Merged via the queue into microsoft:main with commit dddf9c7 Dec 5, 2024
23 checks passed
@mikeharder mikeharder deleted the openapi3-peer branch December 5, 2024 19:36
archerzz pushed a commit to archerzz/typespec that referenced this pull request Dec 17, 2024
Fixes warnings (or potentially errors) when installing
`@typespec/openapi3`:

```
$ npx yarn add @typespec/[email protected]

yarn add v1.22.22
info No lockfile found.
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...

warning " > @typespec/[email protected]" has unmet peer dependency "@typespec/compiler@~0.62.0".
warning " > @typespec/[email protected]" has unmet peer dependency "@typespec/http@~0.62.0".
warning " > @typespec/[email protected]" has unmet peer dependency "@typespec/versioning@~0.62.0".
warning " > @typespec/[email protected]" has unmet peer dependency "@typespec/openapi@~0.62.0".

warning "@typespec/openapi3 > @readme/[email protected]" has unmet peer dependency "openapi-types@>=7".
```

The first 4 warnings are expected, but the peer dependency on
`openapi-types` should either be satisfied by `@typespec/openapi3`
itself, or be declared as a peer dependency of `@typespec/openapi3`
itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants