Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check type name that MUST use keys that match the regular expression: ^[a-zA-Z0-9.-_]+$. #5006

Merged
merged 27 commits into from
Nov 15, 2024
Merged

Check type name that MUST use keys that match the regular expression: ^[a-zA-Z0-9.-_]+$. #5006

merged 27 commits into from
Nov 15, 2024

Conversation

skywing918
Copy link
Member

@skywing918 skywing918 commented Nov 7, 2024 •
edited by timotheeguerin
Loading

fix #3889

@skywing918 skywing918 changed the title Check type name that MUST use keys that match the regular expression: ^[a-zA-Z0-9.-_]+$. [WIP] Check type name that MUST use keys that match the regular expression: ^[a-zA-Z0-9.-_]+$. Do Not Review Nov 7, 2024
wanlwanl
wanlwanl reviewed Nov 8, 2024
View reviewed changes
packages/openapi3/src/openapi.ts Outdated Show resolved Hide resolved
packages/openapi3/src/lib.ts Outdated Show resolved Hide resolved
packages/openapi3/src/lib.ts Outdated Show resolved Hide resolved
packages/openapi3/src/openapi.ts Outdated Show resolved Hide resolved
@wanlwanl wanlwanl marked this pull request as ready for review November 12, 2024 09:56
@wanlwanl
Copy link
Member

LGTM

@wanlwanl wanlwanl changed the title [WIP] Check type name that MUST use keys that match the regular expression: ^[a-zA-Z0-9.-_]+$. Do Not Review Check type name that MUST use keys that match the regular expression: ^[a-zA-Z0-9.-_]+$. Nov 13, 2024
@wanlwanl wanlwanl requested a review from chrisradek November 13, 2024 09:48
markcowl
markcowl requested changes Nov 14, 2024
View reviewed changes
packages/openapi3/src/lib.ts Outdated Show resolved Hide resolved
@skywing918 skywing918 requested a review from markcowl November 14, 2024 07:06
@markcowl markcowl self-assigned this Nov 14, 2024
@wanlwanl wanlwanl added this pull request to the merge queue Nov 15, 2024
Merged via the queue into microsoft:main with commit 764325e Nov 15, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanlwanl wanlwanl wanlwanl left review comments

@markcowl markcowl markcowl approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

@chrisradek chrisradek Awaiting requested review from chrisradek

Assignees

@markcowl markcowl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Illegal characters in component keys (Swagger)
3 participants
@skywing918 @wanlwanl @markcowl