[@typespec/http-specs] - Remove handler for majority of the Scenarios #4725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarangan12
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
No changes needing a change description found. |
|
You can try these changes here
|
timotheeguerin
approved these changes
Oct 14, 2024
Scenarios such as format check in UUID, multipart and one scenario where number of query parameters is zero. (If I do not specify anything in the request, it is obviously zero. But, then previous handler is testing that condition only. So, I retained it) |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
As a continuation of #4725, while working on removing the handler for the scenarios in the `typespec-azure` repository, I found some scenarios need added fix in the `spector` library. This PR consists of 2 changes: 1. The header keys must be changed to lowercase before reading and comparing. 2. If the headers and parameters are array values, then we need to handle them seperately. I have tested this change with all the scenarios in both the `typespec` and `typespec-azure` repositories. Once this change is merged, I can open the PR for the scenario changes in `typespec-azure` repository. Please review and approve this PR. Thanks
github-merge-queue bot
pushed a commit
to Azure/typespec-azure
that referenced
this pull request
Oct 16, 2024
…Scenarios (#1691) This is the continuation of the PR microsoft/typespec#4725. This PR handles the removal of handler property in majority of the Scenarios (Except ones related to LRO and that checks the absence of a parameter). All Scenarios are validated and tested. Please review and approve the PR. Thanks
swatkatz
pushed a commit
to swatkatz/typespec
that referenced
this pull request
Nov 5, 2024
…microsoft#4725) This PR handles the removal of `handler` property in majority of the Scenarios. All Scenarios are validated and tested. Please review and approve the PR. Thanks
swatkatz
pushed a commit
to swatkatz/typespec
that referenced
this pull request
Nov 5, 2024
…ft#4751) As a continuation of microsoft#4725, while working on removing the handler for the scenarios in the `typespec-azure` repository, I found some scenarios need added fix in the `spector` library. This PR consists of 2 changes: 1. The header keys must be changed to lowercase before reading and comparing. 2. If the headers and parameters are array values, then we need to handle them seperately. I have tested this change with all the scenarios in both the `typespec` and `typespec-azure` repositories. Once this change is merged, I can open the PR for the scenario changes in `typespec-azure` repository. Please review and approve this PR. Thanks
markcowl
pushed a commit
to markcowl/typespec-azure
that referenced
this pull request
Dec 5, 2024
…Scenarios (Azure#1691) This is the continuation of the PR microsoft/typespec#4725. This PR handles the removal of handler property in majority of the Scenarios (Except ones related to LRO and that checks the absence of a parameter). All Scenarios are validated and tested. Please review and approve the PR. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles the removal of
handlerproperty in majority of the Scenarios. All Scenarios are validated and tested. Please review and approve the PR. Thanks