-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prune unused files #4288
Closed
Closed
Prune unused files #4288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
Issue for the C# client emitter: @typespec/http-client-csharp
label
Aug 28, 2024
API change check API changes are not detected in this pull request. |
m-nash
reviewed
Aug 28, 2024
...rojects/Plugin/Unbranded-TypeSpec/src/Generated/Models/AnonymousBodyRequest.Serialization.cs
Outdated
Show resolved
Hide resolved
JoshLove-msft
commented
Aug 28, 2024
...nerator/TestProjects/Local/Unbranded-TypeSpec/src/Generated/UnbrandedTypeSpecModelFactory.cs
Outdated
Show resolved
Hide resolved
Filed #4289 |
@@ -20,6 +22,7 @@ namespace Microsoft.Generator.CSharp | |||
internal class GeneratedCodeWorkspace | |||
{ | |||
private const string GeneratedFolder = "Generated"; | |||
private const string InternalFolder = "Internal"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this implementation looks very specific to our implementations, should we put it in a place so that others could customize or extend on?
sarangan12
pushed a commit
to sarangan12/typespec
that referenced
this pull request
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4218