Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run decorators on cloned type if the original type wasn't finished #3566

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Do not run decorators on cloned type if the original type wasn't finished #3566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7c2c19
Do not run decorators on cloned type if the original type wasn't fini…
timotheeguerin Jun 11, 2024
2811084
Create fix-clone-type-donot-finish-unfinished-2024-5-11-21-54-41.md
timotheeguerin Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .chronus/changes/fix-clone-type-donot-finish-unfinished-2024-5-11-21-54-41.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
# Change versionKind to one of: internal, fix, dependencies, feature, deprecation, breaking
changeKind: fix
packages:
- "@typespec/compiler"
---

[API] Do not run decorators on cloned type if the original type wasn't finished
5 changes: 4 additions & 1 deletion packages/compiler/src/core/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6512,7 +6512,10 @@ export function createChecker(program: Program): Checker {
* recursively by the caller.
*/
function cloneType<T extends Type>(type: T, additionalProps: Partial<T> = {}): T {
const clone = finishType(initializeClone(type, additionalProps));
let clone = initializeClone(type, additionalProps);
if (type.isFinished) {
clone = finishType(clone);
}
const projection = projectionsByType.get(type);
if (projection) {
projectionsByType.set(clone, projection);
Expand Down
Loading