-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve completion and onhover in VSCode for decorator and extended model #3280
improve completion and onhover in VSCode for decorator and extended model #3280
Conversation
All changed packages have been documented.
Show changes
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3280/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3280/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have the value world PR that should be merged very soon hopefully. It had object value and array value. Those should be the ones that we autocomplete here instead. Because at this point autocompleting a model like this doesn't make that much sense
by the "value world", do you mean we will have a new way to define/expose an object value instead of leveraging existing model expression? |
yes exactly, with |
…decorator-model-arg
…decorator-model-arg
…decorator-model-arg
@timotheeguerin , I have updated the PR accordingly. please help to review again. thanks. And is there any way that we can get notified in advance for this kind of big change in typespec? That will be helpful for us to collaborate and do planning better. thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great overall, such a nice addition, there is a few little things missing but thanks for this.
.chronus/changes/improve completion-support-in-ide-2024-4-6-16-27-17.md
Outdated
Show resolved
Hide resolved
…decorator-model-arg
…-27-17.md Co-authored-by: Timothee Guerin <[email protected]>
add following feature
closes #3130, closes #2228, closes #1956