Get rid of rush and move to pnpm #2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/2775/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/2775/ |
timotheeguerin
commented
Jan 3, 2024
| @@ -68,7 +68,7 @@ | |||
| "test": "vitest run", | |||
| "test:watch": "vitest -w", | |||
| "test-official": "vitest run --coverage --reporter=junit --reporter=default --no-file-parallelism", | |||
| "e2e": "vitest run --config ./vitest.config.e2e.ts", | |||
| "e2e:disabled": "vitest run --config ./vitest.config.e2e.ts", | |||
There was a problem hiding this comment.
Renable before merging - just failing now due to unreleased feature and e2e test run got lost
timotheeguerin
requested review from
bterlson,
daviwil,
markcowl and
allenjzhang
as code owners
timotheeguerin
changed the title
timotheeguerin
changed the title
timotheeguerin
added a commit
to Azure/typespec-azure
that referenced
this pull request
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the opinionated (wrongly so most of the time) middleman that brings more config pain than value.
Things to check: