Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatter: Fix valueof should keep parentheses in union and array expression #2686

Merged

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Nov 21, 2023

fix #2632

Copy link
Contributor

Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status):
Playground: https://cadlplayground.z22.web.core.windows.net/prs/2686/

Website: https://tspwebsitepr.z22.web.core.windows.net/prs/2686/

@timotheeguerin timotheeguerin enabled auto-merge (squash) November 28, 2023 00:22
@timotheeguerin timotheeguerin merged commit 05b57fd into microsoft:main Nov 28, 2023
10 checks passed
@timotheeguerin timotheeguerin deleted the fix/formatter-keep-parens-valueof branch November 28, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type assignment checks are order-dependent for union with valueof member
2 participants