Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to prettier 3.1 #2666

Merged
merged 5 commits into from
Nov 14, 2023

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Nov 13, 2023

@timotheeguerin timotheeguerin marked this pull request as ready for review November 13, 2023 20:59
Copy link
Contributor

Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status):
Playground: https://cadlplayground.z22.web.core.windows.net/prs/2666/

Website: https://tspwebsitepr.z22.web.core.windows.net/prs/2666/

@tjprescott
Copy link
Member

Why do we want to do this? The blog post says it is experimental.

@timotheeguerin
Copy link
Member Author

Why do we want to do this? The blog post says it is experimental.

THere is just a new flag for some new ternary formatting that is experimental, the package itself isn't

@tjprescott
Copy link
Member

THere is just a new flag for some new ternary formatting that is experimental, the package itself isn't

From the diff in the PR it seems that flag is on. Why do we need to update prettier in the first place?

@timotheeguerin
Copy link
Member Author

There is 2 changes in the changelog to ternary. 1 it retrinroduce the nesting which is the change you are seeing now. We can also enable the experimental flag which we don't which would flatten it back and move more things inline in some cases.

For why to update, 1 is why not? it is always good to be up to date with dependencies and not have years of backlog which we endup having a rush to fix something one day. 2nd there is currently an issue with prettier that fail install on windows randomly so hopefully this gets fixed here.

@timotheeguerin timotheeguerin merged commit bc62493 into microsoft:main Nov 14, 2023
@timotheeguerin timotheeguerin deleted the upgrade/prettier-3.1 branch November 14, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants