Temporarily pin Node 20 to 20.5 to avoid Babel error #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviwil
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status): Website: https://cadlwebsite.z1.web.core.windows.net/prs/2373/ |
daviwil
force-pushed
the
fix-babel-error
branch
from
8dc8945 to
6549632
Compare
|
Nevermind, figured it out :) |
daviwil
force-pushed
the
fix-babel-error
branch
from
6549632 to
4b0c954
Compare
timotheeguerin
approved these changes
Sep 6, 2023
Closed
|
This appears to be a regression in Node |
|
I have node v 20.5.1 installed on my machine still fails to run...! why..? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like CI is failing due to an issue with Babel.js conflicting with Node 20.6:
babel/babel#15927
vitejs/vite#14299
For now, let's try pinning Node 20.x to 20.5 until the issue gets fixed in Babel.
Comparable
typespec-azurerepo PR: https://github.com/Azure/typespec-azure/pull/3502Issue https://github.com/Azure/typespec-azure/issues/3504 tracks the work to un-pin the Node version.