Fix issues with multiple copies of compiler core being loaded #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguerrera
requested review from
bterlson,
daviwil,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
Changes in this PR will be published to the following url to try(check status of Cadl Pull Request Try It pipeline for publish status): Website: https://cadlwebsite.z1.web.core.windows.net/prs/1627/ |
tjprescott
reviewed
Feb 7, 2023
tjprescott
previously approved these changes
Feb 7, 2023
nguerrera
force-pushed
the
shared-symbol
branch
from
9dee1b1 to
26b6dc4
Compare
|
I pushed more changes that actually fix #1625, but it's smelly and I'm not sure about the best way to handle it better or if this is OK. |
nguerrera
force-pushed
the
shared-symbol
branch
from
26b6dc4 to
d59436c
Compare
nguerrera
dismissed
tjprescott’s stale review
Dismissing approval since I substantially added to this. :)
nguerrera
commented
Feb 7, 2023
nguerrera
commented
Feb 7, 2023
nguerrera
changed the title
daviwil
approved these changes
Feb 9, 2023
bterlson
reviewed
Feb 9, 2023
| "changes": [ | ||
| { | ||
| "packageName": "@cadl-lang/rest", | ||
| "comment": "Fix issues with multiple copies of compiler core being loaded.", |
There was a problem hiding this comment.
My only thought is it might be nice to be a bit more explicit about what you're fixing here.
bterlson
approved these changes
Feb 9, 2023
nguerrera
commented
Feb 9, 2023
common/changes/@cadl-lang/compiler/shared-symbol_2023-02-07-15-24.json
Outdated
Show resolved
Hide resolved
nguerrera
commented
Feb 9, 2023
common/changes/@cadl-lang/rest/shared-symbol_2023-02-07-17-20.json
Outdated
Show resolved
Hide resolved
nguerrera
commented
Feb 9, 2023
common/changes/@cadl-lang/compiler/shared-symbol_2023-02-07-15-24.json
Outdated
Show resolved
Hide resolved
nguerrera
commented
Feb 9, 2023
common/changes/@cadl-lang/rest/shared-symbol_2023-02-07-17-20.json
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1625