Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenAI - Handle Discriminated Model with only a Discriminated Property #4935

Closed
jorgerangel-msft opened this issue Oct 31, 2024 · 0 comments · Fixed by #4936
Closed

OpenAI - Handle Discriminated Model with only a Discriminated Property #4935

jorgerangel-msft opened this issue Oct 31, 2024 · 0 comments · Fixed by #4936
Assignees
@jorgerangel-msft
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Comments

@jorgerangel-msft
Copy link
Contributor

If the generator encounters a model that has a discriminator property but no discriminated subtypes, the generator does not generat the "unknown" discriminated subtype for this model which leads to issues in the serialization code. This model at question in OpenAI is RealtimeResponseStatusDetails.
Image
@jorgerangel-msft jorgerangel-msft added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Oct 31, 2024
@jorgerangel-msft jorgerangel-msft self-assigned this Oct 31, 2024
@jorgerangel-msft jorgerangel-msft mentioned this issue Oct 31, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 1, 2024
@jorgerangel-msft
[http-client-csharp] fix: gen. unknown discriminator model when discr…
b7d351b 
…iminator prop exists (#4936)

fixes: #4935
swatkatz pushed a commit to swatkatz/typespec that referenced this issue Nov 5, 2024
@jorgerangel-msft
[http-client-csharp] fix: gen. unknown discriminator model when discr…
1a859b8 
…iminator prop exists (microsoft#4936)

fixes: microsoft#4935
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorgerangel-msft jorgerangel-msft

Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Milestone
No milestone
1 participant
@jorgerangel-msft