Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model extends another allow property to become optional #3539

Closed
timotheeguerin opened this issue Jun 6, 2024 · 1 comment · Fixed by #3659
Closed

Model extends another allow property to become optional #3539

timotheeguerin opened this issue Jun 6, 2024 · 1 comment · Fixed by #3659
Assignees
@witemple-msft
Labels
bug Something isn't working compiler:core Issues for @typespec/compiler triaged:core
Milestone
[2024] July

Comments

@timotheeguerin
Copy link
Member

timotheeguerin commented Jun 6, 2024 •
edited
Loading 

 model Base {
  s: string;
}

model Foo extends Base {
  s?: string;
}

Playground Link

The same thing with template constrain fail which was fixed last sprint but seem like this case remain #3290
Playground
@timotheeguerin timotheeguerin added the bug Something isn't working label Jun 6, 2024
@timotheeguerin timotheeguerin mentioned this issue Jun 6, 2024
Closed
4 tasks
@markcowl markcowl added this to the [2024] July milestone Jun 11, 2024
@markcowl
Copy link
Contributor

P2

@markcowl markcowl added triaged:core compiler:core Issues for @typespec/compiler labels Jun 11, 2024
@witemple-msft witemple-msft mentioned this issue Jun 25, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 10, 2024
@witemple-msft @willmtemple
[core] Disallow overriding a required property with an optional prope…
859f792 
…rty (#3659)

Closes #3539 

This change disallows overriding a required inherited property with an
optional property.

This error does not take precedence over regular property assignability
rules. In case the property _both_ is optional when the overridden
property is required _and_ has a non-assignable type, both errors will
be reported.

---------

Co-authored-by: Will Temple <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@witemple-msft witemple-msft

Labels
bug Something isn't working compiler:core Issues for @typespec/compiler triaged:core
Projects
None yet
Milestone
[2024] July
Development

Successfully merging a pull request may close this issue.

[core] Disallow overriding a required property with an optional property witemple-msft/typespec
3 participants
@timotheeguerin @markcowl @witemple-msft