Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Tm language doesn't highlight escaped identifiers corrrectly #3070

Closed
4 tasks done
timotheeguerin opened this issue Mar 27, 2024 · 0 comments · Fixed by #3069
Closed
4 tasks done

[Bug]: Tm language doesn't highlight escaped identifiers corrrectly #3070

timotheeguerin opened this issue Mar 27, 2024 · 0 comments · Fixed by #3069
Assignees
@timotheeguerin
Labels
bug Something isn't working
Milestone
[2024] April

Comments

@timotheeguerin
Copy link
Member

Describe the bug

image

Reproduction

enum Foo {
  ...Direction,
  `North East`,
  `North West`,
  `South East`,
  `South West`,
}

Checklist
@timotheeguerin timotheeguerin added the bug Something isn't working label Mar 27, 2024
@timotheeguerin timotheeguerin added this to the [2024] April milestone Mar 27, 2024
@timotheeguerin timotheeguerin self-assigned this Mar 27, 2024
@timotheeguerin timotheeguerin mentioned this issue Mar 27, 2024
Merged
timotheeguerin added a commit that referenced this issue Mar 27, 2024
@timotheeguerin
Improve TM language for enums, unions and escaped identifiers (#3069)
ce9c567 
resolves #3070
The tm language wasn't correctly defining the syntax for escaped
identifiers

```
`North West`
```


Enums and unions syntax was also not very accurate and didn't tokenize
everything correctly


## Example of issue before


![image](https://github.com/microsoft/typespec/assets/1031227/ee60f4fe-5eef-4f86-baa5-1cc96b665526)

## After

![image](https://github.com/microsoft/typespec/assets/1031227/38405f18-0fa4-44ba-82f6-594bcd4fcebf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timotheeguerin timotheeguerin

Labels
bug Something isn't working
Projects
None yet
Milestone
[2024] April
Development

Successfully merging a pull request may close this issue.

Improve TM language for enums, unions and escaped identifiers timotheeguerin/typespec
1 participant
@timotheeguerin