-
Notifications
You must be signed in to change notification settings - Fork 226
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
http-client-java, fix eclipse languageserver when tmp folder is corru…
…pted (#5307) ### Situation I somehow encountered a folder corruption situation that the tmp folder for language server is there, but with no Jar file. Language server didn't start correctly, but the exception is thrown only when JSON RPC to the server is performed. <img width="1406" alt="Screenshot 2024-12-11 at 14 23 52" src="https://github.com/user-attachments/assets/1654fabc-bb71-4b81-aab7-b4c24b8afae3"> ### This PR - In case the language server did not start correctly, and user did not explicitly provide a language server path, force a re-download. - If the server failed to start anyway, throw with the process output. ### Test #### Normal first download <img width="1372" alt="Screenshot 2024-12-09 at 20 12 06" src="https://github.com/user-attachments/assets/9126e436-cad2-4a03-9d7c-cb31d5bc4a95"> #### Normal downloaded <img width="1251" alt="Screenshot 2024-12-09 at 20 09 22" src="https://github.com/user-attachments/assets/2deb6fb3-acef-4d4b-8365-8a6ebf3ab3f8"> #### Corrupted folder, we do a re-download <img width="1306" alt="Screenshot 2024-12-09 at 20 08 35" src="https://github.com/user-attachments/assets/d8d56d6f-fd97-4b06-8327-08045cbadbff"> #### Server failed to start anyway, we throw with server output <img width="1383" alt="Screenshot 2024-12-10 at 16 48 25" src="https://github.com/user-attachments/assets/36f56e7d-0b58-4820-8c6f-a33dc559c902">
- Loading branch information
1 parent
f21484e
commit a862ac7
Showing
1 changed file
with
57 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters