#411 Removed default configuration of deprecated rules.

Restored configuration of deprecated parameters and set them to false.

closes #411

additional_rule_metadata.json

@@ -653,7 +653,7 @@
     "issueType": "Warning",
     "severity": "Low",
     "group": "Clarity",
-    "recommendation": "[true, 3],  // we generally recommend making one public class per file ",
+    "recommendation": "[true, 3],  // we generally recommend making one public class per file",
     "level": "Opportunity for Excellence"
   },
   "no-parameter-properties": {

recommended_ruleset.js

@@ -117,7 +117,7 @@ module.exports = {
         "import-name": true,
         "interface-name": true,
         "jsdoc-format": true,
-        "max-classes-per-file": [true, 3],  // we generally recommend making one public class per file 
+        "max-classes-per-file": [true, 3],  // we generally recommend making one public class per file
         "max-file-line-count": true,
         "max-func-body-length": [true, 100, {"ignore-parameters-to-function-regex": "describe"}],
         "max-line-length": [true, 140],
@@ -250,17 +250,17 @@ module.exports = {
          * Deprecated rules.  The following rules are deprecated for various reasons.
          */
         "missing-optional-annotation": false,  // now supported by TypeScript compiler
-        "no-duplicate-case": true,
+        "no-duplicate-case": false,
         "no-duplicate-parameter-names": false, // now supported by TypeScript compiler
         "no-empty-interfaces": false, // use tslint no-empty-interface rule instead
         "no-missing-visibility-modifiers": false, // use tslint member-access rule instead
         "no-multiple-var-decl": false,         // use tslint one-variable-per-declaration rule instead
-        "no-stateless-class": true,
+        "no-stateless-class": false,
         "no-switch-case-fall-through": false,  // now supported by TypeScript compiler
-        "no-var-self": true,
-        "react-tsx-curly-spacing": true,
+        "no-var-self": false,
+        "react-tsx-curly-spacing": false,
         "typeof-compare": false,               // the valid-typeof rule is currently superior to this version
-        "valid-typeof": true,
+        "valid-typeof": false,
     }
 };
 

src/noDuplicateCaseRule.ts

@@ -20,6 +20,7 @@ export class Rule extends Lint.Rules.AbstractRule {
         issueType: 'Error',
         severity: 'Critical',
         level: 'Opportunity for Excellence',
+        recommendation: 'false,',
         group: 'Deprecated',
         commonWeaknessEnumeration: '398, 710'
     };

src/noStatelessClassRule.ts

@@ -24,6 +24,7 @@ export class Rule extends Lint.Rules.AbstractRule {
         issueType: 'Warning',
         severity: 'Important',
         level: 'Opportunity for Excellence',
+        recommendation: 'false,',
         group: 'Deprecated',
         commonWeaknessEnumeration: '398, 710'
     };

src/noVarSelfRule.ts

@@ -22,6 +22,7 @@ export class Rule extends Lint.Rules.AbstractRule {
         severity: 'Important',
         level: 'Opportunity for Excellence',
         group: 'Deprecated',
+        recommendation: 'false,',
         commonWeaknessEnumeration: '398, 710'
     };
 

src/reactTsxCurlySpacingRule.ts

@@ -20,6 +20,7 @@ export class Rule extends Lint.Rules.AbstractRule {
         issueType: 'Warning',
         severity: 'Low',
         level: 'Opportunity for Excellence',
+        recommendation: 'false,',
         group: 'Deprecated'
     };
 

src/validTypeofRule.ts

@@ -20,6 +20,7 @@ export class Rule extends Lint.Rules.AbstractRule {
         issueType: 'Error',
         severity: 'Critical',
         level: 'Opportunity for Excellence',
+        recommendation: 'false,',
         group: 'Deprecated'
     };
 

tslint.json

@@ -72,7 +72,7 @@
       false
     ],
     "missing-jsdoc": true,
-    "missing-optional-annotation": true,
+    "missing-optional-annotation": false,
     "mocha-avoid-only": true,
     "mocha-no-side-effect-code": true,
     "mocha-unneeded-done": true,
@@ -107,13 +107,13 @@
     "no-disable-auto-sanitization": true,
     "no-document-domain": true,
     "no-document-write": true,
-    "no-duplicate-case": true,
-    "no-duplicate-parameter-names": true,
+    "no-duplicate-case": false,
+    "no-duplicate-parameter-names": false,
     "no-duplicate-super": true,
     "no-duplicate-variable": true,
     "no-empty": true,
     "no-empty-interface": true,
-    "no-empty-interfaces": true,
+    "no-empty-interfaces": false,
     "no-empty-line-after-opening-brace": false,
     "no-eval": true,
     "no-exec-script": true,
@@ -139,10 +139,10 @@
     "no-jquery-raw-elements": true,
     "no-magic-numbers": false,
     "no-mergeable-namespace": false,
-    "no-missing-visibility-modifiers": true,
+    "no-missing-visibility-modifiers": false,
     "no-misused-new": true,
     "no-multiline-string": [ true ],
-    "no-multiple-var-decl": true,
+    "no-multiple-var-decl": false,
     "no-namespace": false,
     "no-null-keyword": false,
     "no-octal-literal": true,
@@ -162,7 +162,7 @@
     "no-string-literal": true,
     "no-string-throw": true,
     "no-suspicious-comment": true,
-    "no-switch-case-fall-through": true,
+    "no-switch-case-fall-through": false,
     "no-trailing-whitespace": true,
     "no-typeof-undefined": true,
     "no-unbound-method": false,
@@ -237,7 +237,7 @@
     "react-iframe-missing-sandbox": true,
     "react-no-dangerous-html": true,
     "react-this-binding-issue": true,
-    "react-tsx-curly-spacing": true,
+    "react-tsx-curly-spacing": false,
     "react-unused-props-and-state": true,
     "restrict-plus-operands": false,
     "semicolon": [
@@ -267,7 +267,7 @@
     "typedef-whitespace": [
       false
     ],
-    "typeof-compare": true,
+    "typeof-compare": false,
     "underscore-consistent-invocation": true,
     "unified-signatures": true,
     "use-isnan": true,