Fix import-name options indexing

The options begin at index 0. The previous developer might have gotten it mixed up with initial `true` in the config array which controls `ruleSeverity`, not `ruleArguments`.
microsoft · Jul 19, 2019 · b3b53d2 · b3b53d2
1 parent 34f3347
commit b3b53d2
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 43 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/importNameRule.ts b/src/importNameRule.ts
@@ -45,15 +45,15 @@ export class Rule extends Lint.Rules.AbstractRule {
 
         if (options.ruleArguments instanceof Array) {
             options.ruleArguments.forEach((opt: unknown, index: number) => {
-                if (index === 1 && isObject(opt)) {
+                if (index === 0 && isObject(opt)) {
                     result.replacements = this.extractReplacements(opt);
                 }
 
-                if (index === 2 && Array.isArray(opt)) {
+                if (index === 1 && Array.isArray(opt)) {
                     result.ignoredList = this.extractIgnoredList(opt);
                 }
 
-                if (index === 3 && isObject(opt)) {
+                if (index === 2 && isObject(opt)) {
                     result.config = this.extractConfig(opt);
                 }
             });

diff --git a/src/tests/ImportNameRuleTests.ts b/src/tests/ImportNameRuleTests.ts
@@ -114,7 +114,6 @@ describe('importNameRule', (): void => {
         `;
 
         const options = [
-            true,
             {
                 backbone: 'Backbone',
                 react: 'React',
@@ -132,7 +131,6 @@ describe('importNameRule', (): void => {
         import pqr from 'my-module'
         `;
         const options = [
-            true,
             {
                 'fs/package-name': 'pkg',
                 'abc-tag': 'abc',
@@ -151,7 +149,6 @@ describe('importNameRule', (): void => {
         import Up from 'up-module'
         `;
         const options = [
-            true,
             {
                 'fs/package-name': 'pkg',
                 'abc-tag': 'abc',
@@ -171,7 +168,6 @@ describe('importNameRule', (): void => {
         import Up from 'up-module'
         `;
         const options = [
-            true,
             {
                 'fs/package-name': 'pkg',
                 'abc-tag': 'abc',
@@ -251,7 +247,6 @@ describe('importNameRule', (): void => {
                 `;
 
                 const options = [
-                    true,
                     {},
                     {},
                     {
@@ -268,7 +263,6 @@ describe('importNameRule', (): void => {
                 `;
 
                 const options = [
-                    true,
                     {},
                     {},
                     {
@@ -301,7 +295,6 @@ describe('importNameRule', (): void => {
                 `;
 
                 const options = [
-                    true,
                     {},
                     {},
                     {
@@ -318,7 +311,6 @@ describe('importNameRule', (): void => {
                 `;
 
                 const options = [
-                    true,
                     {},
                     {},
                     {
@@ -351,15 +343,15 @@ describe('importNameRule', (): void => {
                     import GraphqlTag from 'x/y/z/graphql-tag';
                     import graphqlTag from 'x/y/z/graphql-tag';
                 `;
-                const options = [true, {}, {}, { case: 'any-case' }];
+                const options = [{}, {}, { case: 'any-case' }];
                 TestHelper.assertViolationsWithOptions(ruleName, options, script, []);
             });
 
             it('should fail', () => {
                 const script: string = `
                     import gTag from 'x/y/z/graphql-tag';
                 `;
-                const options = [true, {}, {}, { case: 'any-case' }];
+                const options = [{}, {}, { case: 'any-case' }];
                 TestHelper.assertViolationsWithOptions(ruleName, options, script, [
                     {
                         failure: "Misnamed import. Import should be named 'graphqlTag' or 'GraphqlTag' but found 'gTag'",