-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error when using other than 4 channel images with BYOL task #522
Conversation
Thanks for the catch! LGTM. Could you paste the error message you received so it can be referenced in the future? |
When I tried to train a ResNet50 with BYOLTask on EuroSAT data (13 bands), I had this error:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this fixes #337
We were basically hardcoding in_channels=4 since we didn't pass it from BYOLTask to BYOL. I think this likely solves the issue using BYOL with datasets that do not use RGBN NAIP imagery. |
…osoft#522) Co-authored-by: BAHL Gaetan <[email protected]>
…osoft#522) Co-authored-by: BAHL Gaetan <[email protected]>
To avoid shape errors, we pass the
in_channels
argument fromBYOLTask
toBYOL
.