BeninSmallHolderCashews: return geospatial metadata in sample #377
Conversation
adamjstewart
changed the title
instead of storing it in self. Adapt docstring
…into geo-information
|
|
|
Have the test run? Many of the are reported as "expected" I'm still waiting to get approval to sign the CLA. |
|
For first time contributors GitHub requires maintainers to explicitly run the tests (just did). This is a security feature to prevent bitcoin mining on CI resources. We could disable this. |
|
I wouldn't both using |
I'm trying to avoid unconfiguring my environment and configuring it just for that PR. |
|
Ok, I switched to black and installed pre-commit hooks |
|
@calebrob6 did we ever get the CLA issue resolved? |
|
Yes the CLA bot currently works I think |
|
I was still waiting on the approval to sign the CLA (manager in vacation). Now it is signed. Thanks. |
|
will do. I'm about to leave on vacation. I might have to wait after. |
|
I can do it no problem
…On Thu, Feb 24, 2022 at 4:08 AM Alexandre Lacoste ***@***.***> wrote:
will do. I'm about to leave on vacation. I might have to wait after.
—
Reply to this email directly, view it on GitHub
<#377 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIJUTTFSGBUPXDPYNLYPX3U4YNS5ANCNFSM5NCJJ57Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Awesome! |
|
Thanks for the PR @recursix! Hopefully we can get this converted to a |
…oft#377) * exposing geoinformation * restoring white spaces * Returns tile_transform and crs instead of storing it in self. Adapt docstring * adding types * adjust line length * fixing formatting * remove auto-format from another auto-pep8 tool * adjust order of import * radjust autopep8 * passes pre-commit hook * Add Oxford comma * tile_transform -> transform Co-authored-by: Adam J. Stewart <[email protected]>
exposing geoinformation in the return dict of getitem for benin_cashews.py