BaseTask: fix load_from_checkpoint, ignore 'ignore' #2317
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #2314. @calebrob6 can you see if this also fixes your issue?
I think this makes more sense, as
ignore
is more of a class attribute than an instance parameter. It also makes it possible to add subclasses with additional ignores. Downside is that it's technically backwards incompatible and will have to wait until 0.7.0.