Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuakeSet dataset #1997

Merged
merged 18 commits into from
Apr 19, 2024
Merged

QuakeSet dataset #1997

merged 18 commits into from
Apr 19, 2024

Conversation

isaaccorley
Copy link
Collaborator

@isaaccorley isaaccorley commented Apr 15, 2024

This PR adds the QuakeSet dataset from the paper "QuakeSet: A Dataset and Low-Resource Models to Monitor Earthquakes through Sentinel-1", Cambrin et al.. This is also the dataset that will be used for the new ECML-PKDD 2024 Seismic Analysis

Sample plots (plotting (VV, VH, VV / VH) as RGB false color image:

image1
and Monitoring Challenge (SMAC).

image2

@DarthReca @nilsleh

@isaaccorley isaaccorley self-assigned this Apr 15, 2024
@isaaccorley isaaccorley marked this pull request as draft April 15, 2024 02:34
@github-actions github-actions bot added the datasets Geospatial or benchmark datasets label Apr 15, 2024
@adamjstewart adamjstewart added this to the 0.6.0 milestone Apr 15, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation testing Continuous integration testing datamodules PyTorch Lightning datamodules labels Apr 15, 2024
@isaaccorley isaaccorley marked this pull request as ready for review April 15, 2024 23:50
@adamjstewart
Copy link
Collaborator

Drop in coverage is real, you're missing coverage for ImportError

docs/api/non_geo_datasets.csv Outdated Show resolved Hide resolved
torchgeo/datamodules/quakeset.py Show resolved Hide resolved
torchgeo/datasets/quakeset.py Show resolved Hide resolved
@isaaccorley
Copy link
Collaborator Author

Drop in coverage is real, you're missing coverage for ImportError

It only took a few hours to get reported 🫠

@isaaccorley isaaccorley requested a review from nilsleh April 16, 2024 17:37
nilsleh
nilsleh previously approved these changes Apr 17, 2024
torchgeo/datasets/quakeset.py Show resolved Hide resolved
torchgeo/datasets/quakeset.py Outdated Show resolved Hide resolved
torchgeo/datasets/quakeset.py Outdated Show resolved Hide resolved
torchgeo/datasets/quakeset.py Outdated Show resolved Hide resolved
torchgeo/datasets/quakeset.py Outdated Show resolved Hide resolved
@isaaccorley
Copy link
Collaborator Author

@adamjstewart Seems like the classification task tests don't like "validation" as a split but I'm not seeing where it's being fixed for so2sat

@isaaccorley
Copy link
Collaborator Author

We should probably rethink the splits because in torchgeo.datamodules.geo we are hardcoding the setup method to use train, val, test. Removing the one line in QuakeSet dataset requires adding a setup method to the QuakeSet datamodule with 10+ lines. Going to revert back

@isaaccorley
Copy link
Collaborator Author

Any chance we could get this merged today? The competition has already started.

@adamjstewart adamjstewart merged commit 0f06391 into microsoft:main Apr 19, 2024
16 of 17 checks passed
@isaaccorley isaaccorley deleted the datasets/quakeset branch April 19, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datamodules PyTorch Lightning datamodules datasets Geospatial or benchmark datasets documentation Improvements or additions to documentation testing Continuous integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants