Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Download Link AGB Live Woody Biomass dataset #1713

Merged
merged 2 commits into from
Nov 5, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix link
nilsleh committed Nov 5, 2023
commit 6a9679ac8acf06358d3cd055b0128f5017baaa05
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"type": "FeatureCollection", "name": "Aboveground_Live_Woody_Biomass_Density", "crs": {"type": "name", "properties": {"name": "urn:ogc:def:crs:OGC:1.3:CRS84"}}, "features": [{"type": "Feature", "properties": {"tile_id": "00N_000E", "download": "tests/data/agb_live_woody_density/00N_000E.tif", "ObjectId": 1, "Shape__Area": 1245542622548.87, "Shape__Length": 4464169.76558139}, "geometry": {"type": "Polygon", "coordinates": [[[0.0, 0.0], [10.0, 0.0], [10.0, -10.0], [0.0, -10.0], [0.0, 0.0]]]}}]}
{"type": "FeatureCollection", "name": "Aboveground_Live_Woody_Biomass_Density", "crs": {"type": "name", "properties": {"name": "urn:ogc:def:crs:OGC:1.3:CRS84"}}, "features": [{"type": "Feature", "properties": {"tile_id": "00N_000E", "Mg_px_1_download": "tests/data/agb_live_woody_density/00N_000E.tif", "ObjectId": 1, "Shape__Area": 1245542622548.87, "Shape__Length": 4464169.76558139}, "geometry": {"type": "Polygon", "coordinates": [[[0.0, 0.0], [10.0, 0.0], [10.0, -10.0], [0.0, -10.0], [0.0, 0.0]]]}}]}
4 changes: 2 additions & 2 deletions tests/data/agb_live_woody_density/data.py
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@
"type": "Feature",
"properties": {
"tile_id": "00N_000E",
"download": os.path.join(
"Mg_px_1_download": os.path.join(
"tests", "data", "agb_live_woody_density", "00N_000E.tif"
),
"ObjectId": 1,
@@ -74,5 +74,5 @@ def create_file(path: str, dtype: str, num_channels: int) -> None:
json.dump(base_file, f)

for i in base_file["features"]:
filepath = os.path.basename(i["properties"]["download"])
filepath = os.path.basename(i["properties"]["Mg_px_1_download"])
create_file(path=filepath, dtype="int32", num_channels=1)
6 changes: 3 additions & 3 deletions torchgeo/datasets/agb_live_woody_density.py
Original file line number Diff line number Diff line change
@@ -45,8 +45,8 @@ class AbovegroundLiveWoodyBiomassDensity(RasterDataset):
is_image = False

url = (
adamjstewart marked this conversation as resolved.
Show resolved Hide resolved
"https://opendata.arcgis.com/api/v3/datasets/3e8736c8866b458687"
"e00d40c9f00bce_0/downloads/data?format=geojson&spatialRefId=4326"
"https://opendata.arcgis.com/api/v3/datasets/e4bdbe8d6d8d4e32ace7d3"
"6a4aec7b93_0/downloads/data?format=geojson&spatialRefId=4326"
)

base_filename = "Aboveground_Live_Woody_Biomass_Density.geojson"
@@ -123,7 +123,7 @@ def _download(self) -> None:

for item in content["features"]:
download_url(
item["properties"]["download"],
item["properties"]["Mg_px_1_download"],
self.paths,
item["properties"]["tile_id"] + ".tif",
)