Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuroSATDataModule: set mean/std based on bands #1681

Merged
merged 6 commits into from
Oct 20, 2023

Conversation

robmarkcole
Copy link
Contributor

Bands are now used to update the mean and std attributes used in normalisation.

Closes #1634

@github-actions github-actions bot added the datamodules PyTorch Lightning datamodules label Oct 19, 2023
@adamjstewart adamjstewart changed the title Issue 1634 EuroSATDataModule: set mean/std based on bands Oct 19, 2023
@adamjstewart adamjstewart added this to the 0.5.1 milestone Oct 19, 2023
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Feel free to do the same for other data modules if you want.

@adamjstewart adamjstewart enabled auto-merge (squash) October 20, 2023 09:12
@adamjstewart adamjstewart merged commit 4126f46 into microsoft:main Oct 20, 2023
20 checks passed
@robmarkcole robmarkcole deleted the issue-1634 branch October 20, 2023 10:10
nilsleh pushed a commit that referenced this pull request Nov 6, 2023
* Use dicts to generate mean and std

* correctly pass bands

* black format

* Remove unused import

* Simplify

* Import all bands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datamodules PyTorch Lightning datamodules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EuroSATDataModule initialised with 3 bands gives error: mean length and number of channels do not match
2 participants