Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass save_config_kwargs to LightningCLI #1625

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Pass save_config_kwargs to LightningCLI #1625

merged 1 commit into from
Oct 10, 2023

Conversation

robmarkcole
Copy link
Contributor

Fixes #1621

@github-actions github-actions bot added the scripts Training and evaluation scripts label Oct 6, 2023
adamjstewart
adamjstewart approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will give others some time to review in case they disagree

@adamjstewart adamjstewart added this to the 0.5.1 milestone Oct 6, 2023
@calebrob6
Copy link
Member

Good with me

@calebrob6 calebrob6 merged commit 7a793f3 into microsoft:main Oct 10, 2023
20 checks passed
@robmarkcole robmarkcole deleted the fix-wandb branch October 31, 2023 11:42
nilsleh pushed a commit that referenced this pull request Nov 6, 2023
@robmarkcole @nilsleh
Pass save_config_kwargs to LightningCLI (#1625)
b4b2289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjstewart adamjstewart adamjstewart approved these changes

Assignees
No one assigned
Labels
scripts Training and evaluation scripts
Projects
None yet
Milestone
0.5.1
Development

Successfully merging this pull request may close these issues.

Wandb logger conflict using LightningCLI
3 participants
@robmarkcole @calebrob6 @adamjstewart