Allow VectorDataset to accept list of files #1597

adriantre · 2023-09-29T08:24:08Z

Extend on #1442 to implement changes for VectorDataset

NB: Change base branch of this PR when #1442 is merged.
Any feedback on best practices / better approaches for git in this regard is much appreciated.

This reverts commit 84bf62b.

…or_root_to_paths # Conflicts: # tests/datasets/test_geo.py # torchgeo/datasets/landcoverai.py

torchgeo/datasets/geo.py

torchgeo/datasets/landcoverai.py

torchgeo/datasets/chesapeake.py

torchgeo/datasets/geo.py

torchgeo/datasets/chesapeake.py

Adrian Tofting and others added 28 commits September 29, 2023 10:16

Make RasterDataset accept list of files

4ade256

Fix check if str

a0f985d

Use isdir and isfile

a9f6944

Rename root to paths and update type hint

b69625b

Update children of RasterDataset methods using root

b7a51bd

Fix check to cast str to list

d6a0919

Update conf files for RasterDatasets

ce5f474

Add initial suggested test

81833e9

Add workaround for lists LandCoverAIBase

b247861

Add method handle_nonlocal_path for users to override

f569051

Raise RuntimeError to support existing tests

d4f757c

Remove reduntand cast to set

0414f63

Remove required os.exists for paths

2195553

Revert "Remove required os.exists for paths"

61de902

This reverts commit 84bf62b.

Use arg as potitional argument not kwarg

5bed6f3

Improve comments and logs about arg paths

8e80458

Remove misleading comment

b736cef

Change type hint of 'paths' to Iterable

2f7df48

Change type hint of 'paths' to Iterable

a6e5fe1

Remove premature handling of non-local paths

ca5c4bf

Replace root with paths in docstrings

a228cc2

Add versionadded to list_files docstring

c22a6a9

Add versionchanged to docstrings

44f6eb5

Update type of paths in childred of Raster

9dae8c4

Replace docstring for paths in all raster

1311957

Swap root with paths for conf files for raster

697dfd7

Add newline before versionchanged

026ee11

Revert name to root in conf for ChesapeakeCVPR

628801a

github-actions bot added datasets Geospatial or benchmark datasets testing Continuous integration testing labels Sep 29, 2023

github-actions bot added the scripts Training and evaluation scripts label Sep 29, 2023

Test with a real empty directory

8ec2e93

adriantre force-pushed the feature/refactor_vector_root_to_paths branch from 0e77339 to bdb9422 Compare September 29, 2023 13:29

github-actions bot removed documentation Improvements or additions to documentation scripts Training and evaluation scripts labels Sep 29, 2023

Move property files up to GeoDataset

be29b24

adriantre force-pushed the feature/refactor_vector_root_to_paths branch from bdb9422 to be29b24 Compare September 29, 2023 13:34

adriantre added 2 commits September 29, 2023 16:05

Rename root to paths for VectorDataset

0b0ade4

Merge remote-tracking branch 'origin/main' into feature/refactor_vect…

a02c9b1

…or_root_to_paths # Conflicts: # tests/datasets/test_geo.py # torchgeo/datasets/landcoverai.py

github-actions bot removed the testing Continuous integration testing label Sep 29, 2023