Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MoCo/SimCLR transforms update #1357

Merged
merged 5 commits into from
May 23, 2023
Merged

MoCo/SimCLR transforms update #1357

merged 5 commits into from
May 23, 2023

Conversation

isaaccorley
Copy link
Collaborator

  • add random brightness and random contrast
  • fix random grayscale wrong device bug

@isaaccorley isaaccorley requested a review from adamjstewart May 22, 2023 15:26
@github-actions github-actions bot added trainers PyTorch Lightning trainers transforms Data augmentation transforms labels May 22, 2023
@adamjstewart
Copy link
Collaborator

adamjstewart commented May 22, 2023 •
edited
Loading

Can you update SimCLR too?

@adamjstewart
Copy link
Collaborator

Looks like RandomBrightness was added in Kornia 0.6.9. You'll need to update the minimum version in setup.cfg/environment.yml/min-reqs.old

@isaaccorley isaaccorley changed the title MoCo transforms update MoCo/SimCLR transforms update May 23, 2023
@isaaccorley isaaccorley requested a review from adamjstewart May 23, 2023 15:38
@github-actions github-actions bot added the dependencies Packaging and dependencies label May 23, 2023
@adamjstewart adamjstewart added this to the 0.5.0 milestone May 23, 2023
adamjstewart
adamjstewart approved these changes May 23, 2023
View reviewed changes
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing/improving this!

@adamjstewart adamjstewart merged commit 3196dab into microsoft:main May 23, 2023
@isaaccorley isaaccorley deleted the trainers/moco-transforms branch May 23, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjstewart adamjstewart adamjstewart approved these changes

Assignees
No one assigned
Labels
dependencies Packaging and dependencies trainers PyTorch Lightning trainers transforms Data augmentation transforms
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@isaaccorley @adamjstewart