Drop Python 3.8 support #1246
Drop Python 3.8 support #1246
Conversation
github-actions
bot
added
dependencies
|
Discovered a bug in Sphinx in the process of upgrading: sphinx-doc/sphinx#11327 |
| @@ -3,6 +3,9 @@ | |||
|
|
|||
| """Common dataset utilities.""" | |||
|
|
|||
| # https://github.com/sphinx-doc/sphinx/issues/11327 | |||
| from __future__ import annotations | |||
There was a problem hiding this comment.
Had to use this hack to get our docs to build properly. This file gives a preview of what type hints will look like in Python 3.10 when Optional and Union become obsolete.
| rootdir: ~/torchgeo, configfile: pyproject.toml | ||
| plugins: mock-1.11.1, anyio-3.2.1, cov-2.8.1, nbmake-0.5 | ||
| collected 7 items | ||
|
|
||
| tests/datasets/test_foo.py ....... [100%] | ||
|
|
||
| ---------- coverage: platform darwin, python 3.8.11-final-0 ----------- | ||
| ---------- coverage: platform darwin, python 3.10.11-final-0 ----------- |
There was a problem hiding this comment.
Is this a find and replace artifact?
There was a problem hiding this comment.
Nah, just noticed it while grepping around and figured we should pretend it was run on a supported version of Python.
| @@ -3,6 +3,9 @@ | |||
|
|
|||
| """Common dataset utilities.""" | |||
|
|
|||
| # https://github.com/sphinx-doc/sphinx/issues/11327 | |||
| from __future__ import annotations | |||
|
Lol 130 files! I didn't check to see if you missed any "Tuple" --> "tuple", etc. |
|
|
pyupgrade did, this was mostly auto-generated. The only thing I had to do manually was non-Python files and removing imports we no longer use. |
adamjstewart
force-pushed
the
python/3.9
branch
from
65f391f to
e69d669
Compare
adamjstewart
force-pushed
the
python/3.9
branch
from
e69d669 to
252e385
Compare
NEP 29 has officially deprecated Python 3.8 support as of today. In the past we've been hesitant to follow NEP 29 because Google Colab was still running Python 3.7, but they've since upgraded to 3.9 already, so that isn't an issue anymore. PyTorch ostensibly follows NEP 29, and many of our other dependencies will soon drop support for 3.8 in their next release, complicating testing. Also, 3.9 and 3.10 introduce native support for type hints, meaning most of our
from typing import *lines will be removed.