Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SeCo newer version bug fix #1235

Merged
merged 6 commits into from
Apr 14, 2023
Merged

Conversation

isaaccorley
Copy link
Collaborator

I may have a new version of SeCo downloaded, but each patch directory in the version I have contains RGB tifs + directories with individual band tifs. for example the folder seasonal_contrast_100k/01999 contains the following:

20191101T080051_20191101T080824_T36QZH/
20200125T080119_20200125T081343_T36QZH/
20200414T075609_20200414T081030_T36QZH/
20200713T075609_20200713T081050_T36QZH/
20200921T075629_20200921T080225_T36QZH/
20191101T080051_20191101T080824_T36QZH.tif
20200125T080119_20200125T081343_T36QZH.tif
20200414T075609_20200414T081030_T36QZH.tif
20200713T075609_20200713T081050_T36QZH.tif
20200921T075629_20200921T080225_T36QZH.tif

I think the current dataset expects there to not be RGB tifs. This simple fix makes it so that it ignores the RGB tifs since we load RGB bands with the individual band files anyway.

@isaaccorley isaaccorley self-assigned this Apr 12, 2023
@github-actions github-actions bot added the datasets Geospatial or benchmark datasets label Apr 12, 2023
@adamjstewart adamjstewart added this to the 0.4.2 milestone Apr 12, 2023
@adamjstewart
Copy link
Collaborator

Can you update the test data?

It could also be that the 100K version has a different layout than the 1M version. I think that was the case with SSL4EO-S12 too.

@github-actions github-actions bot added the testing Continuous integration testing label Apr 14, 2023
@isaaccorley isaaccorley merged commit 2f4dc77 into microsoft:main Apr 14, 2023
@isaaccorley isaaccorley deleted the seco/dir_list_bug branch April 22, 2023 21:46
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
@adamjstewart adamjstewart modified the milestones: 0.4.2, 0.5.0 Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets testing Continuous integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants