RasterDataset: fix bug when separate_files and no date in regex #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaaccorley
approved these changes
Mar 23, 2023
|
Finally, someone else introduced a bug besides me. |
|
I've introduced far more bugs than you. This bug is rather minor compared to #786. |
calebrob6
pushed a commit
that referenced
this pull request
Apr 10, 2023
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
|
Does 0.4.1 fix this issue? |
|
Yes, it should. Let me know if you still encounter this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced by yours truly waaaaay back in #75.
The reason we haven't discovered this bug until now is that it has extremely limited scope. It only affects
RasterDatasets whereseparate_files = Trueandfilename_regexdoes not contain adategroup. This is exactly 0 of our builtin datasets, but is unfortunately exactly what happened to @TolgaAktas in #1182.Thanks for reporting this @TolgaAktas!