Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing dep on sklearn #230

Closed
adamjstewart opened this issue Nov 9, 2021 · 0 comments · Fixed by #249
Closed

Missing dep on sklearn #230

adamjstewart opened this issue Nov 9, 2021 · 0 comments · Fixed by #249
Milestone
0.1.1

Comments

@adamjstewart
Copy link
Collaborator

We have an optional dep on sklearn, but it's actually required now that we moved the DataModule from trainers to datasets.
@adamjstewart adamjstewart mentioned this issue Nov 16, 2021
Merged
adamjstewart pushed a commit that referenced this issue Nov 16, 2021
@ashnair1
Fix #230 (#249)
b81e0e7 
* Move sklearn to dataset optional reqs

* Move sklean to mandatory reqs
@adamjstewart adamjstewart added this to the 0.2.0 milestone Nov 20, 2021
@adamjstewart adamjstewart mentioned this issue Dec 15, 2021
Merged
adamjstewart pushed a commit that referenced this issue Dec 19, 2021
@ashnair1 @adamjstewart
Fix #230 (#249)
1679d9e 
* Move sklearn to dataset optional reqs

* Move sklean to mandatory reqs
@adamjstewart adamjstewart modified the milestones: 0.2.0, 0.1.1 Jan 1, 2022
yichiac pushed a commit to yichiac/torchgeo that referenced this issue Apr 29, 2023
@ashnair1
Fix microsoft#230 (microsoft#249)
b586c12 
* Move sklearn to dataset optional reqs

* Move sklean to mandatory reqs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.1
Development

Successfully merging a pull request may close this issue.

Make sklearn dependency required ashnair1/torchgeo
1 participant
@adamjstewart