Display an error when '--maximum-failed-tests' is used with a framework not implementing the required capability #4321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk not implementing the required capability
Evangelink
reviewed
Dec 11, 2024
src/Platform/Microsoft.Testing.Platform/Extensions/AbortForMaxFailedTestsExtension.cs
Outdated
Show resolved
Hide resolved
Evangelink
previously approved these changes
Dec 12, 2024
| @@ -713,4 +713,7 @@ Takes one argument as string in the format <value>[h|m|s] where 'value' is | |||
| <value>Test session is aborting due to reaching failures ('{0}') specified by the '--maximum-failed-tests' option.</value> | |||
| <comment>{0} is the number of max failed tests.</comment> | |||
| </data> | |||
| </root> | |||
| <data name="AbortForMaxFailedTestsCapabilityNotAvailable" xml:space="preserve"> | |||
| <value>The current test framework does not support '--maximum-failed-tests'.</value> | |||
There was a problem hiding this comment.
I am wondering if we should add even more details like they need to open a bug on the test framework repo.
Or change message to be The current test framework does not implement correctly the maximum failed test capability
There was a problem hiding this comment.
@Evangelink I chose a slightly different wording to mention the interface name IGracefulStopTestExecutionCapability. Please let me know if you think what I chose is too wordy.
Evangelink
approved these changes
Dec 12, 2024
Evangelink
pushed a commit
to Evangelink/testfx
that referenced
this pull request
Dec 12, 2024
…rk not implementing the required capability (microsoft#4321)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.