Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSTEST0018: DynamicData usage should be valid #3374

Merged
merged 3 commits into from
Jul 31, 2024
Merged

MSTEST0018: DynamicData usage should be valid #3374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4ed176
wip
Evangelink Mar 15, 2024
8aee8d4
WIP
Evangelink Jul 30, 2024
cdb7462
Finish analyzer
Evangelink Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/Adapter/MSTest.TestAdapter/Resources/Resource.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions src/Adapter/MSTest.TestAdapter/Resources/Resource.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,4 +410,7 @@ but received {4} argument(s), with types '{5}'.</value>
<data name="InvalidValue" xml:space="preserve">
<value>Invalid value '{0}' for runsettings entry '{1}', setting will be ignored.</value>
</data>
<data name="DynamicDataShouldBeValidMessageFormat_MemberType" xml:space="preserve">
<value>'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</value>
</data>
</root>
5 changes: 5 additions & 0 deletions src/Adapter/MSTest.TestAdapter/Resources/xlf/Resource.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@ byl však přijat tento počet argumentů: {4} s typy {5}.</target>
<target state="translated">Metoda inicializace třídy {0}.{1} byla zrušena.</target>
<note />
</trans-unit>
<trans-unit id="DynamicDataShouldBeValidMessageFormat_MemberType">
<source>'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</source>
<target state="new">'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</target>
<note />
</trans-unit>
<trans-unit id="Execution_Test_Timeout">
<source>Test '{0}' exceeded execution timeout period.</source>
<target state="translated">Test {0} překročil časový limit spuštění.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Adapter/MSTest.TestAdapter/Resources/xlf/Resource.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@ aber empfing {4} Argument(e) mit den Typen „{5}“.</target>
<target state="translated">Die Initialisierungsmethode "{0}.{1}" der Klasse wurde abgebrochen</target>
<note />
</trans-unit>
<trans-unit id="DynamicDataShouldBeValidMessageFormat_MemberType">
<source>'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</source>
<target state="new">'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</target>
<note />
</trans-unit>
<trans-unit id="Execution_Test_Timeout">
<source>Test '{0}' exceeded execution timeout period.</source>
<target state="translated">Der Test "{0}" hat das Ausführungstimeout überschritten.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Adapter/MSTest.TestAdapter/Resources/xlf/Resource.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@ pero recibió {4} argumento(s), con los tipos "{5}".</target>
<target state="translated">Método de inicialización de clase "{0}.{1}" se canceló</target>
<note />
</trans-unit>
<trans-unit id="DynamicDataShouldBeValidMessageFormat_MemberType">
<source>'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</source>
<target state="new">'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</target>
<note />
</trans-unit>
<trans-unit id="Execution_Test_Timeout">
<source>Test '{0}' exceeded execution timeout period.</source>
<target state="translated">La prueba '{0}' superó el tiempo de espera de ejecución.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Adapter/MSTest.TestAdapter/Resources/xlf/Resource.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@ mais a reçu {4} argument(s), avec les types « {5} ».</target>
<target state="translated">La méthode d’initialisation de la classe « {0}.{1} » a été annulée</target>
<note />
</trans-unit>
<trans-unit id="DynamicDataShouldBeValidMessageFormat_MemberType">
<source>'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</source>
<target state="new">'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</target>
<note />
</trans-unit>
<trans-unit id="Execution_Test_Timeout">
<source>Test '{0}' exceeded execution timeout period.</source>
<target state="translated">Le test '{0}' a dépassé le délai d'attente de l'exécution.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Adapter/MSTest.TestAdapter/Resources/xlf/Resource.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@ ma ha ricevuto {4} argomenti, con tipi "{5}".</target>
<target state="translated">Il metodo di inizializzazione della classe "{0}.{1}" è stato annullato</target>
<note />
</trans-unit>
<trans-unit id="DynamicDataShouldBeValidMessageFormat_MemberType">
<source>'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</source>
<target state="new">'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</target>
<note />
</trans-unit>
<trans-unit id="Execution_Test_Timeout">
<source>Test '{0}' exceeded execution timeout period.</source>
<target state="translated">È stato superato il periodo di timeout per l'esecuzione del test '{0}'.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Adapter/MSTest.TestAdapter/Resources/xlf/Resource.ja.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ but received {4} argument(s), with types '{5}'.</source>
<target state="translated">クラス初期化メソッド '{0}.{1}' が取り消されました</target>
<note />
</trans-unit>
<trans-unit id="DynamicDataShouldBeValidMessageFormat_MemberType">
<source>'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</source>
<target state="new">'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</target>
<note />
</trans-unit>
<trans-unit id="Execution_Test_Timeout">
<source>Test '{0}' exceeded execution timeout period.</source>
<target state="translated">テスト '{0}' は実行タイムアウトを超えました。</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Adapter/MSTest.TestAdapter/Resources/xlf/Resource.ko.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@ but received {4} argument(s), with types '{5}'.</source>
<target state="translated">'클래스 초기화 메서드 '{0}.{1}'이(가) 취소되었습니다.</target>
<note />
</trans-unit>
<trans-unit id="DynamicDataShouldBeValidMessageFormat_MemberType">
<source>'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</source>
<target state="new">'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</target>
<note />
</trans-unit>
<trans-unit id="Execution_Test_Timeout">
<source>Test '{0}' exceeded execution timeout period.</source>
<target state="translated">'{0}' 테스트가 실행 시간 제한을 초과했습니다.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Adapter/MSTest.TestAdapter/Resources/xlf/Resource.pl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@ ale liczba odebranych argumentów to {4} z typami „{5}”.</target>
<target state="translated">Anulowano metodę inicjowania klasy „{0}.{1}”</target>
<note />
</trans-unit>
<trans-unit id="DynamicDataShouldBeValidMessageFormat_MemberType">
<source>'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</source>
<target state="new">'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</target>
<note />
</trans-unit>
<trans-unit id="Execution_Test_Timeout">
<source>Test '{0}' exceeded execution timeout period.</source>
<target state="translated">Test „{0}” przekroczył okres limitu czasu na wykonanie.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Adapter/MSTest.TestAdapter/Resources/xlf/Resource.pt-BR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@ mas {4} argumentos recebidos, com tipos '{5}'.</target>
<target state="translated">O método de inicialização de classe "{0}.{1}" foi cancelado</target>
<note />
</trans-unit>
<trans-unit id="DynamicDataShouldBeValidMessageFormat_MemberType">
<source>'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</source>
<target state="new">'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</target>
<note />
</trans-unit>
<trans-unit id="Execution_Test_Timeout">
<source>Test '{0}' exceeded execution timeout period.</source>
<target state="translated">Teste '{0}' ultrapassou o período de tempo limite de execução.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Adapter/MSTest.TestAdapter/Resources/xlf/Resource.ru.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@ but received {4} argument(s), with types '{5}'.</source>
<target state="translated">Метод инициализации класса "{0}.{1}" отменен</target>
<note />
</trans-unit>
<trans-unit id="DynamicDataShouldBeValidMessageFormat_MemberType">
<source>'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</source>
<target state="new">'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</target>
<note />
</trans-unit>
<trans-unit id="Execution_Test_Timeout">
<source>Test '{0}' exceeded execution timeout period.</source>
<target state="translated">Превышено время ожидания выполнения теста "{0}".</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Adapter/MSTest.TestAdapter/Resources/xlf/Resource.tr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@ ancak, '{5}' türüyle {4} argüman aldı.</target>
<target state="translated">'{0}.{1}' sınıf başlatma yöntemi iptal edildi</target>
<note />
</trans-unit>
<trans-unit id="DynamicDataShouldBeValidMessageFormat_MemberType">
<source>'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</source>
<target state="new">'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</target>
<note />
</trans-unit>
<trans-unit id="Execution_Test_Timeout">
<source>Test '{0}' exceeded execution timeout period.</source>
<target state="translated">'{0}' testi yürütme zaman aşımı süresini aştı.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Adapter/MSTest.TestAdapter/Resources/xlf/Resource.zh-Hans.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@ but received {4} argument(s), with types '{5}'.</source>
<target state="translated">已取消类初始化方法“{0}.{1}”</target>
<note />
</trans-unit>
<trans-unit id="DynamicDataShouldBeValidMessageFormat_MemberType">
<source>'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</source>
<target state="new">'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</target>
<note />
</trans-unit>
<trans-unit id="Execution_Test_Timeout">
<source>Test '{0}' exceeded execution timeout period.</source>
<target state="translated">测试“{0}”的执行超时。</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Adapter/MSTest.TestAdapter/Resources/xlf/Resource.zh-Hant.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@ but received {4} argument(s), with types '{5}'.</source>
<target state="translated">已取消類別初始化方法 '{0}.{1}'</target>
<note />
</trans-unit>
<trans-unit id="DynamicDataShouldBeValidMessageFormat_MemberType">
<source>'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</source>
<target state="new">'[DynamicData]' referenced member '{0}.{1}' should return 'IEnumerable&lt;object[]&gt;', 'IEnumerable&lt;Tuple&gt;` or 'IEnumerable&lt;ValueTuple&gt;'</target>
<note />
</trans-unit>
<trans-unit id="Execution_Test_Timeout">
<source>Test '{0}' exceeded execution timeout period.</source>
<target state="translated">測試 '{0}' 超過執行逾時期限。</target>
Expand Down
1 change: 1 addition & 0 deletions src/Analyzers/MSTest.Analyzers/AnalyzerReleases.Unshipped.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@

Rule ID | Category | Severity | Notes
--------|----------|----------|-------
MSTEST0018 | Usage | Warning | DynamicDataShouldBeValidAnalyzer, [Documentation](https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0018)
MSTEST0034 | Usage | Info | UseClassCleanupBehaviorEndOfClassAnalyzer, [Documentation](https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0034)
Loading
Loading