Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MessageBusProxy.InitAsync to be proxying _messageBus.InitAsync #3300

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Fix MessageBusProxy.InitAsync to be proxying _messageBus.InitAsync #3300

merged 4 commits into from
Jul 22, 2024

Conversation

SimonCropp
Copy link
Contributor

No description provided.

@Evangelink
Copy link
Member

@MarcoRossignoli can you check this one please?

MarcoRossignoli
MarcoRossignoli approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@MarcoRossignoli MarcoRossignoli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, we're not using it at the moment but it should.
We init the concrete message bus where we create the inner one so we never found this potential bug.

@Evangelink Evangelink enabled auto-merge (squash) July 22, 2024 12:44
@SimonCropp
Copy link
Contributor Author

so it would have been a stack overflow?

@Evangelink Evangelink changed the title should MessageBusProxy.InitAsync be proxying to to _messageBus.InitAsync ? Fix MessageBusProxy.InitAsync to be proxying _messageBus.InitAsync Jul 22, 2024
@MarcoRossignoli
Copy link
Contributor

MarcoRossignoli commented Jul 22, 2024 •
edited
Loading

so it would have been a stack overflow?

I suppose yep...I don't know if jitter could optimize it and have an infinite loop/hang, we don't have param.

@Evangelink Evangelink disabled auto-merge July 22, 2024 13:43
@Evangelink Evangelink merged commit 2610262 into microsoft:main Jul 22, 2024
4 of 6 checks passed
@SimonCropp SimonCropp deleted the should-MessageBusProxy.InitAsync-be-proxying-to-_messageBus branch July 22, 2024 22:35
Evangelink pushed a commit that referenced this pull request Aug 2, 2024
@SimonCropp @Evangelink
Fix MessageBusProxy.InitAsync to be proxying _messageBus.InitAsync (#…
c683317 
…3300)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

@MarcoRossignoli MarcoRossignoli MarcoRossignoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonCropp @Evangelink @MarcoRossignoli