Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create build definition with Github failed #105

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Fix create build definition with Github failed #105

merged 2 commits into from
Jul 27, 2020

Conversation

xuzhang3
Copy link
Collaborator

@xuzhang3 xuzhang3 commented Jul 27, 2020

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Issue Number: #72 #65

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

I can't create acceptance test for this scenario:

  1. The test case need a real GitHub service connection and real repository, this will bind the test case to a specific GitHub PAT and repository.
  2. Mock test won't send the real request to GitHub, can't be used to verify the request. The request is verify by service side.

Community post

@xuzhang3 xuzhang3 requested a review from EliiseS July 27, 2020 09:57
@ghost ghost added the size/XS label Jul 27, 2020
@xuzhang3 xuzhang3 changed the title Create build definition with Github failed fix Fix create build definition with Github failed Jul 27, 2020
@EliiseS EliiseS merged commit 79ebfbb into microsoft:master Jul 27, 2020
@siftercoder2
Copy link

I could not find a release where this change has been incorporated. currently, we are forking this repo and creating our own releases. please update releases after 0.0.1.

@xuzhang3
Copy link
Collaborator Author

xuzhang3 commented Sep 9, 2020

@iojas Sorry for the in inconvenience , we are blocked by the GPG signing key. The next version will be in late October.

@EliiseS
Copy link
Member

EliiseS commented Sep 9, 2020

@xuzhang3 What's a GPG signing key?

@xuzhang3
Copy link
Collaborator Author

xuzhang3 commented Sep 9, 2020

@EliiseS GPG key is used to signing the released ADO provider binary package. You can get the details in this document: https://www.terraform.io/docs/registry/providers/publishing.html

@siftercoder2
Copy link

@xuzhang3 no worries. Just wondering what approaches others are using to get around this.

@essic
Copy link

essic commented Oct 6, 2020

Hello @iojas,

I have the same issue. Did you find a work around, around this ?

@xuzhang3
Copy link
Collaborator Author

xuzhang3 commented Oct 9, 2020

@essic Are you using v0.0.1? You can build a new binary from the master branch by yourself or you can wait our next release v0.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants