Updated acceptances tests in azuredevops/internal/acceptancetests/res…

…ource_workitemquery_permissions_test.go
microsoft · Jul 28, 2020 · 2240b85 · 2240b85
1 parent 0e8e71f
commit 2240b85
Showing 1 changed file with 118 additions and 6 deletions.
diff --git a/azuredevops/internal/acceptancetests/resource_workitemquery_permissions_test.go b/azuredevops/internal/acceptancetests/resource_workitemquery_permissions_test.go
@@ -4,16 +4,62 @@
 package acceptancetests
 
 import (
+	"fmt"
 	"regexp"
 	"testing"
 
+	"github.com/ahmetb/go-linq"
 	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
 	"github.com/terraform-providers/terraform-provider-azuredevops/azuredevops/internal/acceptancetests/testutils"
 )
 
+func hclWorkItemQueryPermissions(projectName string, path string, permissions map[string]string) string {
+	projectResource := testutils.HclProjectResource(projectName)
+
+	szPermissions := linq.From(permissions).
+		Select(func(i interface{}) interface{} {
+			kv := i.(linq.KeyValue)
+			return fmt.Sprintf(`%s = "%s"`, kv.Key, kv.Value)
+		}).
+		Aggregate(func(r interface{}, i interface{}) interface{} {
+			if r.(string) == "" {
+				return i
+			}
+			return r.(string) + "\n" + i.(string)
+		}).(string)
+
+	szPath := ""
+	if path != "" {
+		szPath = fmt.Sprintf("path = \"%s\"", path)
+	}
+
+	return fmt.Sprintf(`
+%s
+
+data "azuredevops_group" "project-administrators" {
+	project_id = azuredevops_project.project.id
+	name       = "Project administrators"
+}
+
+resource "azuredevops_workitemquery_permissions" "wiq-permissions" {
+	project_id  = azuredevops_project.project.id
+	principal   = data.azuredevops_group.project-administrators.id
+	%s
+	permissions = {
+		%s
+	}
+}
+`, projectResource, szPath, szPermissions)
+}
+
 func TestAccWorkItemQueryPermissions_SetProjectPermissions(t *testing.T) {
 	projectName := testutils.GenerateResourceName()
-	config := testutils.HclWorkItemQueryPermissions(projectName, "")
+	permissions := map[string]string{
+		"Contribute":        "Allow",
+		"Delete":            "Deny",
+		"ManagePermissions": "NotSet",
+	}
+	config := hclWorkItemQueryPermissions(projectName, "", permissions)
 
 	tfNode := "azuredevops_workitemquery_permissions.wiq-permissions"
 	resource.Test(t, resource.TestCase{
@@ -28,6 +74,57 @@ func TestAccWorkItemQueryPermissions_SetProjectPermissions(t *testing.T) {
 					resource.TestCheckResourceAttrSet(tfNode, "project_id"),
 					resource.TestCheckResourceAttrSet(tfNode, "principal"),
 					resource.TestCheckResourceAttr(tfNode, "permissions.%", "3"),
+					resource.TestCheckResourceAttr(tfNode, "permissions.Contribute", "allow"),
+					resource.TestCheckResourceAttr(tfNode, "permissions.Delete", "deny"),
+					resource.TestCheckResourceAttr(tfNode, "permissions.ManagePermissions", "notset"),
+				),
+			},
+		},
+	})
+}
+
+func TestAccWorkItemQueryPermissions_UpdateProjectPermissions(t *testing.T) {
+	projectName := testutils.GenerateResourceName()
+	config1 := hclWorkItemQueryPermissions(projectName, "", map[string]string{
+		"Contribute":        "Allow",
+		"Delete":            "Deny",
+		"ManagePermissions": "NotSet",
+	})
+	config2 := hclWorkItemQueryPermissions(projectName, "", map[string]string{
+		"Contribute":        "Deny",
+		"Delete":            "Allow",
+		"ManagePermissions": "Deny",
+	})
+
+	tfNode := "azuredevops_workitemquery_permissions.wiq-permissions"
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { testutils.PreCheck(t, nil) },
+		Providers:    testutils.GetProviders(),
+		CheckDestroy: testutils.CheckProjectDestroyed,
+		Steps: []resource.TestStep{
+			{
+				Config: config1,
+				Check: resource.ComposeTestCheckFunc(
+					testutils.CheckProjectExists(projectName),
+					resource.TestCheckResourceAttrSet(tfNode, "project_id"),
+					resource.TestCheckResourceAttrSet(tfNode, "principal"),
+					resource.TestCheckResourceAttr(tfNode, "permissions.%", "3"),
+					resource.TestCheckResourceAttr(tfNode, "permissions.Contribute", "allow"),
+					resource.TestCheckResourceAttr(tfNode, "permissions.Delete", "deny"),
+					resource.TestCheckResourceAttr(tfNode, "permissions.ManagePermissions", "notset"),
+				),
+				Destroy: false,
+			},
+			{
+				Config: config2,
+				Check: resource.ComposeTestCheckFunc(
+					testutils.CheckProjectExists(projectName),
+					resource.TestCheckResourceAttrSet(tfNode, "project_id"),
+					resource.TestCheckResourceAttrSet(tfNode, "principal"),
+					resource.TestCheckResourceAttr(tfNode, "permissions.%", "3"),
+					resource.TestCheckResourceAttr(tfNode, "permissions.Contribute", "deny"),
+					resource.TestCheckResourceAttr(tfNode, "permissions.Delete", "allow"),
+					resource.TestCheckResourceAttr(tfNode, "permissions.ManagePermissions", "deny"),
 				),
 			},
 		},
@@ -36,7 +133,12 @@ func TestAccWorkItemQueryPermissions_SetProjectPermissions(t *testing.T) {
 
 func TestAccWorkItemQueryPermissions_SetSharedQueriesPermissions(t *testing.T) {
 	projectName := testutils.GenerateResourceName()
-	config := testutils.HclWorkItemQueryPermissions(projectName, "/")
+	permissions := map[string]string{
+		"Contribute":        "Allow",
+		"Delete":            "Deny",
+		"ManagePermissions": "NotSet",
+	}
+	config := hclWorkItemQueryPermissions(projectName, "/", permissions)
 
 	tfNode := "azuredevops_workitemquery_permissions.wiq-permissions"
 	resource.Test(t, resource.TestCase{
@@ -51,6 +153,9 @@ func TestAccWorkItemQueryPermissions_SetSharedQueriesPermissions(t *testing.T) {
 					resource.TestCheckResourceAttrSet(tfNode, "project_id"),
 					resource.TestCheckResourceAttrSet(tfNode, "principal"),
 					resource.TestCheckResourceAttr(tfNode, "permissions.%", "3"),
+					resource.TestCheckResourceAttr(tfNode, "permissions.Contribute", "allow"),
+					resource.TestCheckResourceAttr(tfNode, "permissions.Delete", "deny"),
+					resource.TestCheckResourceAttr(tfNode, "permissions.ManagePermissions", "notset"),
 				),
 			},
 		},
@@ -59,7 +164,12 @@ func TestAccWorkItemQueryPermissions_SetSharedQueriesPermissions(t *testing.T) {
 
 func TestAccWorkItemQueryPermissions_SetInvalidFolderPermissions(t *testing.T) {
 	projectName := testutils.GenerateResourceName()
-	config := testutils.HclWorkItemQueryPermissions(projectName, "/invalid")
+	permissions := map[string]string{
+		"Contribute":        "Allow",
+		"Delete":            "Deny",
+		"ManagePermissions": "NotSet",
+	}
+	config := hclWorkItemQueryPermissions(projectName, "/invalid", permissions)
 
 	tfNode := "azuredevops_workitemquery_permissions.wiq-permissions"
 	resource.Test(t, resource.TestCase{
@@ -72,9 +182,11 @@ func TestAccWorkItemQueryPermissions_SetInvalidFolderPermissions(t *testing.T) {
 				ExpectError: regexp.MustCompile("Unable to find query"),
 				Check: resource.ComposeTestCheckFunc(
 					testutils.CheckProjectExists(projectName),
-					resource.TestCheckResourceAttrSet(tfNode, "project_id"),
-					resource.TestCheckResourceAttrSet(tfNode, "principal"),
-					resource.TestCheckResourceAttr(tfNode, "permissions.%", "3"),
+					resource.TestCheckNoResourceAttr(tfNode, "project_id"),
+					resource.TestCheckNoResourceAttr(tfNode, "principal"),
+					resource.TestCheckNoResourceAttr(tfNode, "permissions.Contribute"),
+					resource.TestCheckNoResourceAttr(tfNode, "permissions.Delete"),
+					resource.TestCheckNoResourceAttr(tfNode, "permissions.ManagePermissions"),
 				),
 			},
 		},