Add help text to 'more options' in command palette #9271
Conversation
ghost
added
Area-Accessibility
| <!-- The block for the key chord is only visible | ||
| when there's actual text set as the label. See | ||
| CommandKeyChordVisibilityConverter for details. | ||
| We're setting the accessibility view on the | ||
| border and text block to Raw because otherwise, | ||
| Narrator will read out the key chord. Problem is, | ||
| it already did that because it was the list item's | ||
| "AcceleratorKey". It's redundant. --> |
There was a problem hiding this comment.
I do not believe that you can set a key chord on a setting with nested settings under it -- @zadjii-msft, can you?
There was a problem hiding this comment.
Nevermind, this isn't even the same template. Question stands though!
There was a problem hiding this comment.
Maybe we want nested commands to have key chords in the future? So that when you press them they just open up a menu directly to the command palette filtered to the subcommands???
There was a problem hiding this comment.
That's what I want, tbh. keybinding --> submenu.
There was a problem hiding this comment.
I think that was a "future consideration" for the command palette, but never really thought through too hard
|
("tested using nvda" - did we test with narrator as well? It's inbox, so we must.) |
DHowett
changed the title
Tested with narrator too. It works, but you need to specifically request the help text. That's not ideal, but I think it comes down to narrator's "philosophy" vs NVDA's. Injecting "more options" into the name (automation property) is specific guidance we've been told to avoid too. |
|
Huh. |
DHowett
added
zPreview-Service-Queued-1.13
ghost
requested review from
DHowett
removed
the
zPreview-Service-Queued-1.13
Similar to #9262. This creates another data template specifically for command palette items that open up more options. We leverage the localization key from #9262 to apply help text to this template automatically. Using the data template approach, we now have no need for the `HasNestedComandsVisibilityConverter`, so that set of files is now deleted. The logic to detect nested commands was moved to the template selector. ## Validation Steps Performed Tested using NVDA. Addresses #7908 better (cherry picked from commit d1bf0fc)
|
🎉 Handy links: |
Similar to #9262. This creates another data template specifically for
command palette items that open up more options. We leverage the
localization key from #9262 to apply help text to this template
automatically.
Using the data template approach, we now have no need for the
HasNestedComandsVisibilityConverter, so that set of files is nowdeleted. The logic to detect nested commands was moved to the template
selector.
PR Checklist
Validation Steps Performed
Tested using NVDA.