wpf: base margin height off Y dpi, not X dpi #8039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on the height margin from dpiScale.DpiScaleX to dpiScale.DpiScaleY in Microsoft.Terminal.Wpf.TerminalControl.CalculateMargins().
|
It looks like the Terminal CI builds failed while trying to restore packages.. is there any way to re-execute these tests? |
|
/azp run |
|
Sorry -- our CI can be flaky at times 😄 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
DHowett
approved these changes
Oct 26, 2020
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
You can ignore the Linter. |
ghost
requested review from
DHowett
changed the title
carlos-zamora
approved these changes
Oct 26, 2020
DHowett
pushed a commit
that referenced
this pull request
Oct 28, 2020
This PR resolves an issue I observed in Microsoft.Terminal.Wpf.TerminalControl.CalculateMargins(). Specifically, on line 194 in the project. In this example, the line: `height = controlSize.Height - (this.TerminalRendererSize.Height / dpiScale.DpiScaleX);` is associating the height margin with dpiScale.DpiScaleX instead of dpiScale.DpiScaleY. This PR changes the association to DpiScaleY. Closes #8038 (cherry picked from commit c095a67)
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue I observed in
Microsoft.Terminal.Wpf.TerminalControl.CalculateMargins(). Specifically,
on line 194 in the project. In this example, the line:
height = controlSize.Height - (this.TerminalRendererSize.Height / dpiScale.DpiScaleX);is associating the height margin withdpiScale.DpiScaleX instead of dpiScale.DpiScaleY. This PR changes the
association to DpiScaleY.
Closes #8038