Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize file paths before handing them to the jumplist #7711

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Normalize file paths before handing them to the jumplist #7711

merged 1 commit into from
Sep 23, 2020

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Sep 23, 2020

DestListLogoUri cannot handle paths that are separated with / unless
they're actually URLs. We have to guess somewhat whether something is a
file path and if it appears to be one, normalize it.

Fixes #7706

PR Checklist

@DHowett
Normalize file paths before handing them to the jumplist
8fd3a82 
DestListLogoUri cannot handle paths that are separated with / unless
they're actually URLs. We have to guess somewhat whether something is a
file path and if it appears to be one, normalize it.

Fixes #7706
@DHowett DHowett requested a review from leonMSFT September 23, 2020 17:04
miniksa
miniksa approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah. I like the probability check. Good enough.

@DHowett
Copy link
Member Author

DHowett commented Sep 23, 2020

like the probability check

thanks 😄

@DHowett DHowett merged commit f28ec65 into master Sep 23, 2020
@DHowett DHowett deleted the dev/duhowett/normalztor branch September 23, 2020 23:31
DHowett added a commit that referenced this pull request Oct 19, 2020
@DHowett
Normalize file paths before handing them to the jumplist (#7711)
2592cc4 
DestListLogoUri cannot handle paths that are separated with / unless
they're actually URLs. We have to guess somewhat whether something is a
file path and if it appears to be one, normalize it.

Fixes #7706

(cherry picked from commit f28ec65)
@ghost
Copy link

ghost commented Nov 11, 2020

🎉Windows Terminal v1.4.3141.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Nov 11, 2020
Closed
@ghost
Copy link

ghost commented Nov 11, 2020

🎉Windows Terminal Preview v1.5.3142.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonMSFT leonMSFT leonMSFT approved these changes

@miniksa miniksa miniksa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jumplist doesn't show user defined icons
3 participants
@DHowett @miniksa @leonMSFT