Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add profiles to the Jumplist #7515

Merged
9 commits merged into from
Sep 3, 2020
Merged

Add profiles to the Jumplist #7515

9 commits merged into from
Sep 3, 2020

Conversation

leonMSFT
Copy link
Contributor

@leonMSFT leonMSFT commented Sep 2, 2020 •
edited by DHowett
Loading

This commit introduces Jumplist customization and an item for each
profile to the Jumplist. Selecting an entry in the jumplist will pretty
much just execute wt.exe -p "{profile guid}", and so a new Terminal
will open with the selected profile.

Closes #576

@ghost ghost added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. labels Sep 2, 2020
@zadjii-msft
Copy link
Member

makin' it real hard to not check my work emails, aren't you 😜

carlos-zamora
carlos-zamora requested changes Sep 3, 2020
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I'm confused by something (haven't tested it out). Does this jumplist only get populated when WT is open? Is it populated if I have WT pinned to the taskbar, but it isn't open?

From a code standpoint, I'm mostly bothered by UpdateJumplist using the if(FAILED){ return; } code block over and over again. There has to be a macro you can use to make all of that look nicer.

src/cascadia/TerminalApp/Jumplist.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalApp/Jumplist.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalApp/Jumplist.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalApp/Jumplist.cpp Outdated Show resolved Hide resolved
@ghost ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Sep 3, 2020
DHowett
DHowett requested changes Sep 3, 2020
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's some nice benefits to using winrt::com_ptr around here!

src/cascadia/TerminalApp/Jumplist.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalApp/Jumplist.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalApp/Jumplist.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalApp/Jumplist.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalApp/Jumplist.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalApp/Jumplist.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalApp/Jumplist.h Outdated Show resolved Hide resolved
src/cascadia/TerminalApp/Jumplist.h Outdated Show resolved Hide resolved
src/cascadia/TerminalApp/Jumplist.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalApp/Jumplist.cpp Outdated Show resolved Hide resolved
@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Sep 3, 2020
miniksa
miniksa reviewed Sep 3, 2020
View reviewed changes
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carlos and Dustin got most of the things I saw.

@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Sep 3, 2020
@leonMSFT
Copy link
Contributor Author

leonMSFT commented Sep 3, 2020

@carlos-zamora The jumplist is populated when the Terminal is opened and when the settings json is updated, so it won't be pre-populated straight after install. The jumplist items will stay there even after you close the Terminal though!

@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Sep 3, 2020
@ghost
Copy link

ghost commented Sep 3, 2020

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 9279b7a into master Sep 3, 2020
@ghost ghost deleted the dev/lelian/jump-the-list-back-here branch September 3, 2020 23:35
@skyline75489 skyline75489 mentioned this pull request Sep 5, 2020
Closed
@Sidneys1 Sidneys1 mentioned this pull request Sep 7, 2020
Closed
@skyline75489 skyline75489 mentioned this pull request Sep 13, 2020
Closed
@ghost
Copy link

ghost commented Sep 22, 2020

🎉Windows Terminal Preview v1.4.2652.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Sep 22, 2020
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniksa miniksa miniksa left review comments

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Task Bar jumplist should show items from profile
5 participants
@leonMSFT @zadjii-msft @DHowett @carlos-zamora @miniksa