Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default initialize a CmdPal mode #7263

Merged
3 commits merged into from
Aug 12, 2020
Merged

Default initialize a CmdPal mode #7263

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77966cf
default initialize a mode
leonMSFT Aug 12, 2020
05ae666
should probably init this one as well just in case
leonMSFT Aug 12, 2020
27cbf5c
this sounds a bit better?
leonMSFT Aug 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/cascadia/TerminalApp/CommandPalette.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,21 @@ using namespace winrt::Windows::Foundation::Collections;
namespace winrt::TerminalApp::implementation
{
CommandPalette::CommandPalette() :
_switcherStartIdx{ 0 }
_switcherStartIdx{ 0 },
_anchorKey{ VirtualKey::None }
leonMSFT marked this conversation as resolved.
Show resolved Hide resolved
{
InitializeComponent();

_filteredActions = winrt::single_threaded_observable_vector<winrt::TerminalApp::Command>();
_allCommands = winrt::single_threaded_vector<winrt::TerminalApp::Command>();
_allTabActions = winrt::single_threaded_vector<winrt::TerminalApp::Command>();

// GH#7254 - default initialize a mode
_currentMode = CommandPaletteMode::ActionMode;
leonMSFT marked this conversation as resolved.
Show resolved Hide resolved
SearchBoxText(RS_(L"CommandPalette_SearchBox/PlaceholderText"));
NoMatchesText(RS_(L"CommandPalette_NoMatchesText/Text"));
ControlName(RS_(L"CommandPaletteControlName"));

if (CommandPaletteShadow())
{
// Hook up the shadow on the command palette to the backdrop that
Expand Down